Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Unified Diff: components/ntp_tiles/most_visited_sites.cc

Issue 2668943002: provide static popular sites for first run (Closed)
Patch Set: Move default site definition into resource file Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_tiles/most_visited_sites.cc
diff --git a/components/ntp_tiles/most_visited_sites.cc b/components/ntp_tiles/most_visited_sites.cc
index ca75d4c77cd7a01006ebc850b30225b43ca05d70..64592cb00febd1252fe4c1e26dc6f2978595d6a4 100644
--- a/components/ntp_tiles/most_visited_sites.cc
+++ b/components/ntp_tiles/most_visited_sites.cc
@@ -420,8 +420,12 @@ void MostVisitedSites::OnPopularSitesDownloaded(bool success) {
return;
}
- // Re-build the tile list. Once done, this will notify the observer.
- BuildCurrentTiles();
+ // Only build the tiles if there haven't been any. Otherwise, the UI should
+ // not flicker.
+ if (current_tiles_.empty()) {
sfiera 2017/02/09 12:39:06 Can this actually happen? For a new user, we shoul
fhorschig 2017/02/09 15:30:18 Removed completely.
+ // Re-build the tile list. Once done, this will notify the observer.
+ BuildCurrentTiles();
+ }
}
void MostVisitedSites::OnIconMadeAvailable(const GURL& site_url,

Powered by Google App Engine
This is Rietveld 408576698