components/ntp_tiles/most_visited_sites_unittest.cc - Issue 2668943002: provide static popular sites for first run

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_tiles/most_visited_sites_unittest.cc

Issue 2668943002: provide static popular sites for first run (Closed)

Patch Set: most_visited_unittest registers prefs properly. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/ntp_tiles/most_visited_sites_unittest.cc

diff --git a/components/ntp_tiles/most_visited_sites_unittest.cc b/components/ntp_tiles/most_visited_sites_unittest.cc

index 9c166090ffd9ef8ca301cfa2a2ae68e5254f7206..a4c040626ce2c9fffdd549d1369038f595958f8d 100644

--- a/components/ntp_tiles/most_visited_sites_unittest.cc

+++ b/components/ntp_tiles/most_visited_sites_unittest.cc

@@ -207,9 +207,8 @@ class PopularSitesFactoryForTest {

url_request_context_(new net::TestURLRequestContextGetter(

base::ThreadTaskRunnerHandle::Get())),

worker_pool_owner_(/*max_threads=*/2, "PopularSitesFactoryForTest.") {

+ PopularSitesImpl::RegisterProfilePrefs(pref_service->registry());

if (enabled) {

- PopularSitesImpl::RegisterProfilePrefs(pref_service->registry());

prefs_->SetString(prefs::kPopularSitesOverrideCountry, "IN");

prefs_->SetString(prefs::kPopularSitesOverrideVersion, "7");