components/ntp_tiles/DEPS - Issue 2668943002: provide static popular sites for first run

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/ntp_tiles/DEPS

Issue 2668943002: provide static popular sites for first run (Closed)

Patch Set: most_visited_unittest registers prefs properly. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+components/data_use_measurement/core",	2 "+components/data_use_measurement/core",

3 "+components/favicon",	3 "+components/favicon",

4 "+components/favicon_base",	4 "+components/favicon_base",

5 "+components/google/core/browser",	5 "+components/google/core/browser",

	6 "+components/grit",

6 "+components/image_fetcher",	7 "+components/image_fetcher",

7 "+components/history/core/browser",	8 "+components/history/core/browser",

8 "+components/pref_registry",	9 "+components/pref_registry",

9 "+components/prefs",	10 "+components/prefs",

10 "+components/rappor",	11 "+components/rappor",

	12 "+components/resources:components_resources",
	sdefresne 2017/02/14 12:37:35 There is no directory named components/resources:c There is no directory named components/resources:components_resources. I guess you copied this line from "gn check" output and it does not belong in this file. Please remove. fhorschig 2017/02/14 17:24:15 Gone. Show quoted text On 2017/02/14 12:37:35, sdefresne wrote: > There is no directory named components/resources:components_resources. I guess > you copied this line from "gn check" output and it does not belong in this file. > Please remove. Gone.
11 "+components/search_engines",	13 "+components/search_engines",

12 "+components/suggestions",	14 "+components/suggestions",

13 "+components/sync_preferences",	15 "+components/sync_preferences",

14 "+components/url_formatter",	16 "+components/url_formatter",

15 "+components/variations",	17 "+components/variations",

16 "+jni",	18 "+jni",

17 "+net",	19 "+net",

18 "+ui/gfx",	20 "+ui/gfx",

	21 "+ui/base/resource",

19 ]	22 ]

OLD	NEW

« components/ntp_tiles/BUILD.gn ('K') | « components/ntp_tiles/BUILD.gn ('k') | components/ntp_tiles/most_visited_sites.cc » ('j') | components/ntp_tiles/popular_sites_impl.cc » ('J')