Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: third_party/libwebm/BUILD.gn

Issue 266893002: Add GN targets for third_party/libwebm (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/libwebm/BUILD.gn
diff --git a/third_party/libwebm/BUILD.gn b/third_party/libwebm/BUILD.gn
new file mode 100644
index 0000000000000000000000000000000000000000..68c43ea1e836497eb7316f93d18ac794de93eb30
--- /dev/null
+++ b/third_party/libwebm/BUILD.gn
@@ -0,0 +1,19 @@
+# Copyright (c) 2014 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+source_set("libwebm") {
+ sources = [
+ "source/mkvmuxer.cpp",
+ "source/mkvmuxerutil.cpp",
+ "source/mkvwriter.cpp",
+ ]
+
+ # mkvmuxerutil.cpp redefines the _CRT_RAND_S macro. This is the only thing
+ # that blocks this target from using Chromium compiler settings.
+ configs -= [ "//build/config/compiler:chromium_code" ]
+ configs += [ "//build/config/compiler:no_chromium_code" ]
+
+ # TODO: Is the "libwebm_nacl" target used anywhere? If so, implement it in GN
brettw 2014/05/05 17:43:05 I think you can remove this comment. With GN toolc
ckocagil 2014/05/06 04:57:45 I don't really understand. Doesn't nacl have its o
brettw 2014/05/14 16:40:14 In GN you don't need a separate target to compile
+ # after GN gets nacl target capability.
+}
« no previous file with comments | « BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698