Add GN targets for third_party/libwebm

Add GN targets for third_party/libwebm

R=brettw@chromium.org
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271056

[brettw, 2014-05-05 17:43:05]

lgtm

https://codereview.chromium.org/266893002/diff/1/third_party/libwebm/BUILD.gn
File third_party/libwebm/BUILD.gn (right):

https://codereview.chromium.org/266893002/diff/1/third_party/libwebm/BUILD.gn...
third_party/libwebm/BUILD.gn:17: # TODO: Is the "libwebm_nacl" target used
anywhere? If so, implement it in GN
I think you can remove this comment. With GN toolchain support we wouldn't have
a separate target name for the nacl one, just blocks to set the nacl-specific
flags:
  if (is_nacl) ... 
I don't see anything different in the nacl gyp file, so I think NaCl should
"just work" for this target.

[ckocagil, 2014-05-06 04:57:45]

https://codereview.chromium.org/266893002/diff/1/third_party/libwebm/BUILD.gn
File third_party/libwebm/BUILD.gn (right):

https://codereview.chromium.org/266893002/diff/1/third_party/libwebm/BUILD.gn...
third_party/libwebm/BUILD.gn:17: # TODO: Is the "libwebm_nacl" target used
anywhere? If so, implement it in GN
On 2014/05/05 17:43:05, brettw wrote:
> I think you can remove this comment. With GN toolchain support we wouldn't
have
> a separate target name for the nacl one, just blocks to set the nacl-specific
> flags:
>   if (is_nacl) ... 
> I don't see anything different in the nacl gyp file, so I think NaCl should
> "just work" for this target.

I don't really understand. Doesn't nacl have its own toolchain and output
format? So, does it not need toolchain support and another target (like
libwebm_nacl in GYP)?

[ckocagil, 2014-05-14 08:28:46]

Ping in case this went unnoticed, I'd like to understand your comment before
committing this.

[brettw, 2014-05-14 16:40:14]

Sorry, missed this.

https://codereview.chromium.org/266893002/diff/1/third_party/libwebm/BUILD.gn
File third_party/libwebm/BUILD.gn (right):

https://codereview.chromium.org/266893002/diff/1/third_party/libwebm/BUILD.gn...
third_party/libwebm/BUILD.gn:17: # TODO: Is the "libwebm_nacl" target used
anywhere? If so, implement it in GN
In GN you don't need a separate target to compile for a different toolchain. The
nacl build of libwebm would run this file and it gets output to a parallel
directory tree. If there are nacl-specific conditions, you can just write if
(is_nacl) inside this file.

See the toolchains section of https://code.google.com/p/chromium/wiki/GNLanguage
more

But the short answer is to just delete this comment.

[ckocagil, 2014-05-16 13:54:17]

The CQ bit was checked by ckocagil@chromium.org

[commit-bot: I haz the power, 2014-05-16 13:54:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ckocagil@chromium.org/266893002/20001

[commit-bot: I haz the power, 2014-05-16 15:49:29]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[commit-bot: I haz the power, 2014-05-16 15:52:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-16 15:52:46]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)

[ckocagil, 2014-05-16 18:00:33]

The CQ bit was checked by ckocagil@chromium.org

[commit-bot: I haz the power, 2014-05-16 18:01:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ckocagil@chromium.org/266893002/40001

[commit-bot: I haz the power, 2014-05-16 18:16:15]

Change committed as 271056