Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Unified Diff: tools/perf/benchmarks/memory.py

Issue 2668923002: [tools/perf] Enable memory mobile benchmarks only on Android (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/memory.py
diff --git a/tools/perf/benchmarks/memory.py b/tools/perf/benchmarks/memory.py
index bbd540763be331ce362da3537c2affee02b8b869..d669a12cafd5c51e9f136092e2b2555b2d8bfe42 100644
--- a/tools/perf/benchmarks/memory.py
+++ b/tools/perf/benchmarks/memory.py
@@ -51,9 +51,7 @@ class _MemoryInfra(perf_benchmark.PerfBenchmark):
options.clear_sytem_cache_for_browser_and_profile_on_start = True
-# TODO(bashi): Workaround for http://crbug.com/532075.
-# @benchmark.Enabled('android') shouldn't be needed.
-@benchmark.Enabled('android')
+@benchmark.Enabled('android') # catapult:#3176
class MemoryBenchmarkTop10Mobile(_MemoryInfra):
"""Measure foreground/background memory on top 10 mobile page set.
@@ -78,7 +76,7 @@ class MemoryBenchmarkTop10Mobile(_MemoryInfra):
return not _IGNORED_STATS_RE.search(value.name)
-@benchmark.Disabled('win', 'mac', 'linux') # https://crbug.com/687258
+@benchmark.Enabled('android') # catapult:#3176
class MemoryBenchmarkTop10MobileStress(MemoryBenchmarkTop10Mobile):
"""Run top 10 mobile page set without closing/restarting the browser.
@@ -153,9 +151,7 @@ class LongRunningDualBrowserBenchmark(_MemoryInfra):
return not _IGNORED_STATS_RE.search(value.name)
-# TODO(bashi): Workaround for http://crbug.com/532075
-# @benchmark.Enabled('android') shouldn't be needed.
-@benchmark.Enabled('android')
+@benchmark.Enabled('android') # catapult:#3176
class RendererMemoryBlinkMemoryMobile(_MemoryInfra):
"""Timeline based benchmark for measuring memory consumption on mobile
sites on which blink's memory consumption is relatively high.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698