third_party/WebKit/Source/wtf/text/WTFStringTest.cpp - Issue 2668903003: Replace WTF::emptyString{16Bit}() with a static global

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/text/WTFStringTest.cpp

Issue 2668903003: Replace WTF::emptyString{16Bit}() with a static global (Closed)

Patch Set: Replace WTF::emptyString{16Bit}() with a static global Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/text/WTFStringTest.cpp

diff --git a/third_party/WebKit/Source/wtf/text/WTFStringTest.cpp b/third_party/WebKit/Source/wtf/text/WTFStringTest.cpp

index b8adf4972f082cf86e7aa7bd79a883fda47dd305..081384c1fd3a194f5bd2a7cfba8d584bf904dfe7 100644

--- a/third_party/WebKit/Source/wtf/text/WTFStringTest.cpp

+++ b/third_party/WebKit/Source/wtf/text/WTFStringTest.cpp

@@ -48,7 +48,7 @@ TEST(StringTest, ASCII) {

EXPECT_STREQ("", output.data());

// Empty String.

- output = emptyString().ascii();

+ output = emptyString.ascii();

EXPECT_STREQ("", output.data());

// Regular String.

@@ -489,7 +489,7 @@ TEST(StringTest, StringPrinter) {

toCStringThroughPrinter(String("\x18\x19\x1A\x1B\x1C\x1D\x1E\x1F", 8)));

EXPECT_EQ(CString("\"\\u007F\\u0080\\u0081\""),

toCStringThroughPrinter("\x7F\x80\x81"));

- EXPECT_EQ(CString("\"\""), toCStringThroughPrinter(emptyString()));

+ EXPECT_EQ(CString("\"\""), toCStringThroughPrinter(emptyString));

EXPECT_EQ(CString("<null>"), toCStringThroughPrinter(String()));

static const UChar unicodeSample[] = {0x30C6, 0x30B9,

« no previous file with comments | « third_party/WebKit/Source/wtf/text/WTFString.cpp ('k') | no next file » | no next file with comments »