third_party/WebKit/Source/wtf/text/StringViewTest.cpp - Issue 2668903003: Replace WTF::emptyString{16Bit}() with a static global

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/text/StringViewTest.cpp

Issue 2668903003: Replace WTF::emptyString{16Bit}() with a static global (Closed)

Patch Set: Replace WTF::emptyString{16Bit}() with a static global Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/text/StringViewTest.cpp

diff --git a/third_party/WebKit/Source/wtf/text/StringViewTest.cpp b/third_party/WebKit/Source/wtf/text/StringViewTest.cpp

index 71c3252284f04b229782474129850e6ac87667ba..7c41186010d9acb9182398eac9b1d66bd1f00b7a 100644

--- a/third_party/WebKit/Source/wtf/text/StringViewTest.cpp

+++ b/third_party/WebKit/Source/wtf/text/StringViewTest.cpp

@@ -366,7 +366,7 @@ TEST(StringViewTest, IsEmpty) {

}

TEST(StringViewTest, ToString) {

- EXPECT_EQ(emptyString().impl(), StringView("").toString().impl());

+ EXPECT_EQ(emptyString.impl(), StringView("").toString().impl());

EXPECT_EQ(nullAtom.impl(), StringView().toString().impl());

// NOTE: All the construction tests also check toString().

}