third_party/WebKit/Source/web/tests/KeyboardTest.cpp - Issue 2668903003: Replace WTF::emptyString{16Bit}() with a static global

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/KeyboardTest.cpp

Issue 2668903003: Replace WTF::emptyString{16Bit}() with a static global (Closed)

Patch Set: Replace WTF::emptyString{16Bit}() with a static global Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/KeyboardTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/KeyboardTest.cpp b/third_party/WebKit/Source/web/tests/KeyboardTest.cpp

index a94195e361eba605c236290c367ed53a4a1066b6..8c14efb6f083252c3c46c93f9b9be8da2dce1b06 100644

--- a/third_party/WebKit/Source/web/tests/KeyboardTest.cpp

+++ b/third_party/WebKit/Source/web/tests/KeyboardTest.cpp

@@ -56,7 +56,7 @@ class KeyboardTest : public testing::Test {

WebKeyboardEvent createFakeKeyboardEvent(char keyCode,

int modifiers,

WebInputEvent::Type type,

- const String& key = emptyString()) {

+ const String& key = emptyString) {

WebKeyboardEvent event(type, modifiers, WebInputEvent::TimeStampForTesting);

event.text[0] = keyCode;

event.windowsKeyCode = keyCode;