third_party/WebKit/Source/platform/fonts/shaping/RunSegmenterTest.cpp - Issue 2668903003: Replace WTF::emptyString{16Bit}() with a static global

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/RunSegmenterTest.cpp

Issue 2668903003: Replace WTF::emptyString{16Bit}() with a static global (Closed)

Patch Set: Replace WTF::emptyString{16Bit}() with a static global Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/fonts/SymbolsIteratorTest.cpp ('k') | third_party/WebKit/Source/platform/loader/fetch/MemoryCache.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/shaping/RunSegmenterTest.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/shaping/RunSegmenterTest.cpp b/third_party/WebKit/Source/platform/fonts/shaping/RunSegmenterTest.cpp

index 833057dba30108a9914bb59738150a71826ed970..080bdeb863a753f7cb08162535993de7e3ca4266 100644

--- a/third_party/WebKit/Source/platform/fonts/shaping/RunSegmenterTest.cpp

+++ b/third_party/WebKit/Source/platform/fonts/shaping/RunSegmenterTest.cpp

@@ -44,7 +44,7 @@ class RunSegmenterTest : public testing::Test {

protected:

void CheckRuns(const Vector<SegmenterTestRun>& runs,

FontOrientation orientation) {

- String text(emptyString16Bit());

+ String text(emptyString16Bit);

Vector<SegmenterExpectedRun> expect;

for (auto& run : runs) {

unsigned lengthBefore = text.length();

@@ -91,7 +91,7 @@ class RunSegmenterTest : public testing::Test {

CheckRuns(runs, FontOrientation::Horizontal);

TEST_F(RunSegmenterTest, Empty) {

- String empty(emptyString16Bit());

+ String empty(emptyString16Bit);

RunSegmenter::RunSegmenterRange segmenterRange = {

0, 0, USCRIPT_INVALID_CODE, OrientationIterator::OrientationKeep};

RunSegmenter runSegmenter(empty.characters16(), empty.length(),