third_party/WebKit/Source/platform/fonts/OrientationIteratorTest.cpp - Issue 2668903003: Replace WTF::emptyString{16Bit}() with a static global

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/OrientationIteratorTest.cpp

Issue 2668903003: Replace WTF::emptyString{16Bit}() with a static global (Closed)

Patch Set: Replace WTF::emptyString{16Bit}() with a static global Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/SharedBufferChunkReader.cpp ('k') | third_party/WebKit/Source/platform/fonts/ScriptRunIteratorTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/OrientationIteratorTest.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/OrientationIteratorTest.cpp b/third_party/WebKit/Source/platform/fonts/OrientationIteratorTest.cpp

index 1eaa8f28a0cb03c942b5c82d3782e3b073e56c49..126093f0c3663bbb75de464d81d9bd144373524f 100644

--- a/third_party/WebKit/Source/platform/fonts/OrientationIteratorTest.cpp

+++ b/third_party/WebKit/Source/platform/fonts/OrientationIteratorTest.cpp

@@ -26,7 +26,7 @@ struct ExpectedRun {

class OrientationIteratorTest : public testing::Test {

protected:

void CheckRuns(const Vector<TestRun>& runs) {

- String text(emptyString16Bit());

+ String text(emptyString16Bit);

Vector<ExpectedRun> expect;

for (auto& run : runs) {

text.append(String::fromUTF8(run.text.c_str()));

@@ -60,7 +60,7 @@ class OrientationIteratorTest : public testing::Test {

CheckRuns(runs);

TEST_F(OrientationIteratorTest, Empty) {

- String empty(emptyString16Bit());

+ String empty(emptyString16Bit);

OrientationIterator orientationIterator(empty.characters16(), empty.length(),

FontOrientation::VerticalMixed);

unsigned limit = 0;