third_party/WebKit/Source/modules/websockets/WebSocketHandleImpl.cpp - Issue 2668903003: Replace WTF::emptyString{16Bit}() with a static global

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/websockets/WebSocketHandleImpl.cpp

Issue 2668903003: Replace WTF::emptyString{16Bit}() with a static global (Closed)

Patch Set: Replace WTF::emptyString{16Bit}() with a static global Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp ('k') | third_party/WebKit/Source/platform/SharedBufferChunkReader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/websockets/WebSocketHandleImpl.cpp

diff --git a/third_party/WebKit/Source/modules/websockets/WebSocketHandleImpl.cpp b/third_party/WebKit/Source/modules/websockets/WebSocketHandleImpl.cpp

index efc1aa3e66eaf7fa9facc2ed9344570cbd2bca7b..9c863dd42c969b49d57695a8473482b68f6ab00c 100644

--- a/third_party/WebKit/Source/modules/websockets/WebSocketHandleImpl.cpp

+++ b/third_party/WebKit/Source/modules/websockets/WebSocketHandleImpl.cpp

@@ -33,7 +33,7 @@ WebSocketHandleImpl::~WebSocketHandleImpl() {

NETWORK_DVLOG(1) << this << " deleted";

if (m_websocket)

- m_websocket->StartClosingHandshake(kAbnormalShutdownOpCode, emptyString());

+ m_websocket->StartClosingHandshake(kAbnormalShutdownOpCode, emptyString);

}

void WebSocketHandleImpl::initialize(InterfaceProvider* interfaceProvider) {

@@ -64,7 +64,7 @@ void WebSocketHandleImpl::connect(const KURL& url,

m_websocket->AddChannelRequest(

url, protocols, origin, firstPartyForCookies,

- userAgentOverride.isNull() ? emptyString() : userAgentOverride,

+ userAgentOverride.isNull() ? emptyString : userAgentOverride,

m_clientBinding.CreateInterfacePtrAndBind(

Platform::current()

->currentThread()

@@ -119,7 +119,7 @@ void WebSocketHandleImpl::close(unsigned short code, const String& reason) {

NETWORK_DVLOG(1) << this << " close(" << code << ", " << reason << ")";

m_websocket->StartClosingHandshake(code,

- reason.isNull() ? emptyString() : reason);

+ reason.isNull() ? emptyString : reason);

}

void WebSocketHandleImpl::disconnect() {