third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp - Issue 2668903003: Replace WTF::emptyString{16Bit}() with a static global

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp

Issue 2668903003: Replace WTF::emptyString{16Bit}() with a static global (Closed)

Patch Set: Replace WTF::emptyString{16Bit}() with a static global Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp

diff --git a/third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp b/third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp

index 84b82c21bef3177b3fb10aec278fbb4735886000..5d31822573a062c4d279ad8671b0075d7b8f67bc 100644

--- a/third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp

+++ b/third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp

@@ -111,8 +111,8 @@ ScriptPromise NavigatorShare::share(ScriptState* scriptState,

m_clients.insert(client);

ScriptPromise promise = resolver->promise();

- m_service->Share(shareData.hasTitle() ? shareData.title() : emptyString(),

- shareData.hasText() ? shareData.text() : emptyString(),

+ m_service->Share(shareData.hasTitle() ? shareData.title() : emptyString,

+ shareData.hasText() ? shareData.text() : emptyString,

doc->completeURL(shareData.url()),

convertToBaseCallback(WTF::bind(&ShareClientImpl::callback,

wrapPersistent(client))));