Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1019)

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentAppManager.cpp

Issue 2668903003: Replace WTF::emptyString{16Bit}() with a static global (Closed)
Patch Set: Replace WTF::emptyString{16Bit}() with a static global Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/payments/PaymentAppManager.cpp
diff --git a/third_party/WebKit/Source/modules/payments/PaymentAppManager.cpp b/third_party/WebKit/Source/modules/payments/PaymentAppManager.cpp
index fd96130b87489e5e2c0603430e594c745c0916c4..3b06ab4b89514864115f6954d81580f6a88e9236 100644
--- a/third_party/WebKit/Source/modules/payments/PaymentAppManager.cpp
+++ b/third_party/WebKit/Source/modules/payments/PaymentAppManager.cpp
@@ -25,9 +25,9 @@ template <>
struct TypeConverter<PaymentAppOptionPtr, blink::PaymentAppOption> {
static PaymentAppOptionPtr Convert(const blink::PaymentAppOption& input) {
PaymentAppOptionPtr output = PaymentAppOption::New();
- output->name = input.hasName() ? input.name() : WTF::emptyString();
+ output->name = input.hasName() ? input.name() : WTF::emptyString;
output->icon = input.hasIcon() ? input.icon() : WTF::String();
- output->id = input.hasId() ? input.id() : WTF::emptyString();
+ output->id = input.hasId() ? input.id() : WTF::emptyString;
if (input.hasEnabledMethods()) {
output->enabled_methods =
WTF::Vector<WTF::String>(input.enabledMethods());
@@ -40,7 +40,7 @@ template <>
struct TypeConverter<PaymentAppManifestPtr, blink::PaymentAppManifest> {
static PaymentAppManifestPtr Convert(const blink::PaymentAppManifest& input) {
PaymentAppManifestPtr output = PaymentAppManifest::New();
- output->name = input.hasName() ? input.name() : WTF::emptyString();
+ output->name = input.hasName() ? input.name() : WTF::emptyString;
output->icon = input.hasIcon() ? input.icon() : WTF::String();
if (input.hasOptions()) {
for (size_t i = 0; i < input.options().size(); ++i) {

Powered by Google App Engine
This is Rietveld 408576698