third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.h - Issue 2668903003: Replace WTF::emptyString{16Bit}() with a static global

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.h

Issue 2668903003: Replace WTF::emptyString{16Bit}() with a static global (Closed)

Patch Set: Replace WTF::emptyString{16Bit}() with a static global Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/app_banner/AppBannerController.cpp ('k') | third_party/WebKit/Source/modules/fetch/Response.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.h

diff --git a/third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.h b/third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.h

index af868e47cd07866e45a439aa95395d06d94ccc1d..e675240f4e72c6e6952bfbc9a4a7d57ff8bebdfc 100644

--- a/third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.h

+++ b/third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.h

@@ -30,7 +30,7 @@ class MODULES_EXPORT FederatedCredential final : public SiteBoundCredential {

// TODO(mkwst): This is a stub, as we don't yet have any support on the

// Chromium-side.

- const String& protocol() const { return emptyString(); }

+ const String& protocol() const { return emptyString; }

private:

FederatedCredential(WebFederatedCredential*);