third_party/WebKit/Source/core/testing/DictionaryTest.cpp - Issue 2668903003: Replace WTF::emptyString{16Bit}() with a static global

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/testing/DictionaryTest.cpp

Issue 2668903003: Replace WTF::emptyString{16Bit}() with a static global (Closed)

Patch Set: Replace WTF::emptyString{16Bit}() with a static global Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/testing/DictionaryTest.cpp

diff --git a/third_party/WebKit/Source/core/testing/DictionaryTest.cpp b/third_party/WebKit/Source/core/testing/DictionaryTest.cpp

index 07dea6b738fca23238a6c950563b1d1d11ea185b..6a73fe1132f3f32f1b03dfc0e99dd4e31b2a6387 100644

--- a/third_party/WebKit/Source/core/testing/DictionaryTest.cpp

+++ b/third_party/WebKit/Source/core/testing/DictionaryTest.cpp

@@ -173,12 +173,12 @@ String DictionaryTest::stringFromIterable(

ExecutionContext* executionContext = scriptState->getExecutionContext();

DictionaryIterator iterator = iterable.getIterator(executionContext);

if (iterator.isNull())

- return emptyString();

+ return emptyString;

bool firstLoop = true;

while (iterator.next(executionContext, exceptionState)) {

if (exceptionState.hadException())

- return emptyString();

+ return emptyString;

if (firstLoop)

firstLoop = false;