Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Unified Diff: third_party/WebKit/Source/core/page/PagePopupController.cpp

Issue 2668903003: Replace WTF::emptyString{16Bit}() with a static global (Closed)
Patch Set: Replace WTF::emptyString{16Bit}() with a static global Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/PagePopupController.cpp
diff --git a/third_party/WebKit/Source/core/page/PagePopupController.cpp b/third_party/WebKit/Source/core/page/PagePopupController.cpp
index 11f197cb726952f8ca2d3270ebbc14e4098e74af..c5fe74e5b39797bfce0e4b466dadfcc57be5ccef 100644
--- a/third_party/WebKit/Source/core/page/PagePopupController.cpp
+++ b/third_party/WebKit/Source/core/page/PagePopupController.cpp
@@ -79,7 +79,7 @@ String PagePopupController::localizeNumberString(const String& numberString) {
String PagePopupController::formatMonth(int year, int zeroBaseMonth) {
if (!m_popupClient)
- return emptyString();
+ return emptyString;
DateComponents date;
date.setMonthsSinceEpoch((year - 1970) * 12.0 + zeroBaseMonth);
return m_popupClient->locale().formatDateTime(date, Locale::FormatTypeMedium);
@@ -87,7 +87,7 @@ String PagePopupController::formatMonth(int year, int zeroBaseMonth) {
String PagePopupController::formatShortMonth(int year, int zeroBaseMonth) {
if (!m_popupClient)
- return emptyString();
+ return emptyString;
DateComponents date;
date.setMonthsSinceEpoch((year - 1970) * 12.0 + zeroBaseMonth);
return m_popupClient->locale().formatDateTime(date, Locale::FormatTypeShort);
@@ -97,7 +97,7 @@ String PagePopupController::formatWeek(int year,
int weekNumber,
const String& localizedDateString) {
if (!m_popupClient)
- return emptyString();
+ return emptyString;
DateComponents week;
bool setWeekResult = week.setWeek(year, weekNumber);
DCHECK(setWeekResult);
« no previous file with comments | « third_party/WebKit/Source/core/page/CreateWindow.cpp ('k') | third_party/WebKit/Source/core/style/QuotesData.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698