Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp

Issue 2668903003: Replace WTF::emptyString{16Bit}() with a static global (Closed)
Patch Set: Replace WTF::emptyString{16Bit}() with a static global Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp
diff --git a/third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp b/third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp
index f5a503cc9dd8d00c388f5aa990dbe38fb6ff50bc..f0a5b5b1a93486925d978332136b26c9037a99ec 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp
+++ b/third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp
@@ -81,11 +81,11 @@ String findMagicComment(const String& content, const String& name) {
while (true) {
pos = content.reverseFind(name, pos);
if (pos == kNotFound)
- return emptyString();
+ return emptyString;
// Check for a /\/[\/*][@#][ \t]/ regexp (length of 4) before found name.
if (pos < 4)
- return emptyString();
+ return emptyString;
pos -= 4;
if (content[pos] != '/')
continue;
@@ -102,7 +102,7 @@ String findMagicComment(const String& content, const String& name) {
if (multiline) {
closingCommentPos = content.find("*/", equalSignPos + 1);
if (closingCommentPos == kNotFound)
- return emptyString();
+ return emptyString;
}
break;
@@ -123,7 +123,7 @@ String findMagicComment(const String& content, const String& name) {
String disallowedChars("\"' \t");
for (unsigned i = 0; i < match.length(); ++i) {
if (disallowedChars.find(match[i]) != kNotFound)
- return emptyString();
+ return emptyString;
}
return match;
@@ -985,7 +985,7 @@ DEFINE_TRACE(InspectorStyleSheet) {
static String styleSheetURL(CSSStyleSheet* pageStyleSheet) {
if (pageStyleSheet && !pageStyleSheet->contents()->baseURL().isEmpty())
return pageStyleSheet->contents()->baseURL().getString();
- return emptyString();
+ return emptyString;
}
String InspectorStyleSheet::finalURL() {

Powered by Google App Engine
This is Rietveld 408576698