Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Unified Diff: third_party/WebKit/Source/core/html/track/vtt/VTTRegion.cpp

Issue 2668903003: Replace WTF::emptyString{16Bit}() with a static global (Closed)
Patch Set: Replace WTF::emptyString{16Bit}() with a static global Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/track/vtt/VTTRegion.cpp
diff --git a/third_party/WebKit/Source/core/html/track/vtt/VTTRegion.cpp b/third_party/WebKit/Source/core/html/track/vtt/VTTRegion.cpp
index 57b1c10fa75df0979f7e26323b50280728396f6c..772bca0fb86139c7c732c00ee58e64cb1ec37fb3 100644
--- a/third_party/WebKit/Source/core/html/track/vtt/VTTRegion.cpp
+++ b/third_party/WebKit/Source/core/html/track/vtt/VTTRegion.cpp
@@ -84,7 +84,7 @@ static bool isNonPercentage(double value,
}
VTTRegion::VTTRegion()
- : m_id(emptyString()),
+ : m_id(emptyString),
m_width(defaultWidth),
m_heightInLines(defaultHeightInLines),
m_regionAnchor(FloatPoint(defaultAnchorPointX, defaultAnchorPointY)),
@@ -165,7 +165,7 @@ void VTTRegion::setScroll(const AtomicString& value,
ExceptionState& exceptionState) {
DEFINE_STATIC_LOCAL(const AtomicString, upScrollValueKeyword, ("up"));
- if (value != emptyString() && value != upScrollValueKeyword) {
+ if (value != emptyString && value != upScrollValueKeyword) {
exceptionState.throwDOMException(
SyntaxError, "The value provided ('" + value +
"') is invalid. The 'scroll' property must be either "

Powered by Google App Engine
This is Rietveld 408576698