Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Unified Diff: third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp

Issue 2668903003: Replace WTF::emptyString{16Bit}() with a static global (Closed)
Patch Set: Replace WTF::emptyString{16Bit}() with a static global Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp
diff --git a/third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp b/third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp
index b8ed06674e46345757fa92fa2ee800c35e4de7e3..33662c86cdfd791c0227c3fa08ebca0775d32cb3 100644
--- a/third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp
+++ b/third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp
@@ -100,7 +100,7 @@ static const String& rightKeyword() {
}
static const String& horizontalKeyword() {
- return emptyString();
+ return emptyString;
}
static const String& verticalGrowingLeftKeyword() {
@@ -273,7 +273,7 @@ const String& VTTCue::vertical() const {
return verticalGrowingRightKeyword();
default:
NOTREACHED();
- return emptyString();
+ return emptyString;
}
}
@@ -406,7 +406,7 @@ const String& VTTCue::align() const {
return rightKeyword();
default:
NOTREACHED();
- return emptyString();
+ return emptyString;
}
}
@@ -1103,7 +1103,7 @@ void VTTCue::parseSettings(const String& inputString) {
return;
if (!lineIsAuto() || m_cueSize != 100 || m_writingDirection != Horizontal)
- m_regionId = emptyString();
+ m_regionId = emptyString;
}
void VTTCue::applyUserOverrideCSSProperties() {

Powered by Google App Engine
This is Rietveld 408576698