third_party/WebKit/Source/core/html/forms/TimeInputType.cpp - Issue 2668903003: Replace WTF::emptyString{16Bit}() with a static global

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/TimeInputType.cpp

Issue 2668903003: Replace WTF::emptyString{16Bit}() with a static global (Closed)

Patch Set: Replace WTF::emptyString{16Bit}() with a static global Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/forms/TimeInputType.cpp

diff --git a/third_party/WebKit/Source/core/html/forms/TimeInputType.cpp b/third_party/WebKit/Source/core/html/forms/TimeInputType.cpp

index c055d73957dc5ed010ad63432c9f190a5726d733..c5b928130058f33bcbe43915bc223b5ae5c6d5ec 100644

--- a/third_party/WebKit/Source/core/html/forms/TimeInputType.cpp

+++ b/third_party/WebKit/Source/core/html/forms/TimeInputType.cpp

@@ -127,7 +127,7 @@ String TimeInputType::formatDateTimeFieldsState(

const DateTimeFieldsState& dateTimeFieldsState) const {

if (!dateTimeFieldsState.hasHour() || !dateTimeFieldsState.hasMinute() ||

!dateTimeFieldsState.hasAMPM())

- return emptyString();

+ return emptyString;

if (dateTimeFieldsState.hasMillisecond() &&

dateTimeFieldsState.millisecond()) {

return String::format(