third_party/WebKit/Source/core/html/forms/FormController.cpp - Issue 2668903003: Replace WTF::emptyString{16Bit}() with a static global

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/FormController.cpp

Issue 2668903003: Replace WTF::emptyString{16Bit}() with a static global (Closed)

Patch Set: Replace WTF::emptyString{16Bit}() with a static global Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/forms/FormController.cpp

diff --git a/third_party/WebKit/Source/core/html/forms/FormController.cpp b/third_party/WebKit/Source/core/html/forms/FormController.cpp

index 975daedb27b8d1f76f7105630fdeccbbd9d08996..e5776ac5eae98041f8d389f49250320cd475c2e0 100644

--- a/third_party/WebKit/Source/core/html/forms/FormController.cpp

+++ b/third_party/WebKit/Source/core/html/forms/FormController.cpp

@@ -61,7 +61,7 @@ void FormControlState::serializeTo(Vector<String>& stateVector) const {

DCHECK(!isFailure());

stateVector.push_back(String::number(m_values.size()));

for (const auto& value : m_values)

- stateVector.push_back(value.isNull() ? emptyString() : value);

+ stateVector.push_back(value.isNull() ? emptyString : value);

}

FormControlState FormControlState::deserialize(