Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Unified Diff: third_party/WebKit/Source/core/html/forms/DateTimeFieldsState.cpp

Issue 2668903003: Replace WTF::emptyString{16Bit}() with a static global (Closed)
Patch Set: Replace WTF::emptyString{16Bit}() with a static global Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/forms/DateTimeFieldsState.cpp
diff --git a/third_party/WebKit/Source/core/html/forms/DateTimeFieldsState.cpp b/third_party/WebKit/Source/core/html/forms/DateTimeFieldsState.cpp
index ccfb51763e32af7669dbc228ddbd14ac5a0d15d8..4591ddb74e95b57ca615c6997afc652367a6b00f 100644
--- a/third_party/WebKit/Source/core/html/forms/DateTimeFieldsState.cpp
+++ b/third_party/WebKit/Source/core/html/forms/DateTimeFieldsState.cpp
@@ -87,19 +87,18 @@ DateTimeFieldsState DateTimeFieldsState::restoreFormControlState(
FormControlState DateTimeFieldsState::saveFormControlState() const {
FormControlState state;
- state.append(hasYear() ? String::number(m_year) : emptyString());
- state.append(hasMonth() ? String::number(m_month) : emptyString());
- state.append(hasDayOfMonth() ? String::number(m_dayOfMonth) : emptyString());
- state.append(hasHour() ? String::number(m_hour) : emptyString());
- state.append(hasMinute() ? String::number(m_minute) : emptyString());
- state.append(hasSecond() ? String::number(m_second) : emptyString());
- state.append(hasMillisecond() ? String::number(m_millisecond)
- : emptyString());
- state.append(hasWeekOfYear() ? String::number(m_weekOfYear) : emptyString());
+ state.append(hasYear() ? String::number(m_year) : emptyString);
+ state.append(hasMonth() ? String::number(m_month) : emptyString);
+ state.append(hasDayOfMonth() ? String::number(m_dayOfMonth) : emptyString);
+ state.append(hasHour() ? String::number(m_hour) : emptyString);
+ state.append(hasMinute() ? String::number(m_minute) : emptyString);
+ state.append(hasSecond() ? String::number(m_second) : emptyString);
+ state.append(hasMillisecond() ? String::number(m_millisecond) : emptyString);
+ state.append(hasWeekOfYear() ? String::number(m_weekOfYear) : emptyString);
if (hasAMPM())
state.append(m_ampm == AMPMValueAM ? "A" : "P");
else
- state.append(emptyString());
+ state.append(emptyString);
return state;
}

Powered by Google App Engine
This is Rietveld 408576698