third_party/WebKit/Source/core/html/forms/ChooserOnlyTemporalInputTypeView.cpp - Issue 2668903003: Replace WTF::emptyString{16Bit}() with a static global

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/ChooserOnlyTemporalInputTypeView.cpp

Issue 2668903003: Replace WTF::emptyString{16Bit}() with a static global (Closed)

Patch Set: Replace WTF::emptyString{16Bit}() with a static global Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/forms/BaseTemporalInputType.cpp ('k') | third_party/WebKit/Source/core/html/forms/DateInputType.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/forms/ChooserOnlyTemporalInputTypeView.cpp

diff --git a/third_party/WebKit/Source/core/html/forms/ChooserOnlyTemporalInputTypeView.cpp b/third_party/WebKit/Source/core/html/forms/ChooserOnlyTemporalInputTypeView.cpp

index 3139a5545fcdab8309fc6d00e83d29e744367808..26e8be5da29b7f3ee8b56f5f461d9d8e7ff6bdb7 100644

--- a/third_party/WebKit/Source/core/html/forms/ChooserOnlyTemporalInputTypeView.cpp

+++ b/third_party/WebKit/Source/core/html/forms/ChooserOnlyTemporalInputTypeView.cpp

@@ -124,7 +124,7 @@ void ChooserOnlyTemporalInputTypeView::didChooseValue(const String& value) {

void ChooserOnlyTemporalInputTypeView::didChooseValue(double value) {

DCHECK(std::isfinite(value) || std::isnan(value));

if (std::isnan(value))

- element().setValue(emptyString(), DispatchInputAndChangeEvent);

+ element().setValue(emptyString, DispatchInputAndChangeEvent);

else

element().setValueAsNumber(value, ASSERT_NO_EXCEPTION,

DispatchInputAndChangeEvent);