Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: third_party/WebKit/Source/core/html/TextControlElement.cpp

Issue 2668903003: Replace WTF::emptyString{16Bit}() with a static global (Closed)
Patch Set: Replace WTF::emptyString{16Bit}() with a static global Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/TextControlElement.cpp
diff --git a/third_party/WebKit/Source/core/html/TextControlElement.cpp b/third_party/WebKit/Source/core/html/TextControlElement.cpp
index ab28711b2d572a43255acb003e5a2ca3b7a58c89..1286574aecb2df48cb31c388a30bacdcc8aeb0c0 100644
--- a/third_party/WebKit/Source/core/html/TextControlElement.cpp
+++ b/third_party/WebKit/Source/core/html/TextControlElement.cpp
@@ -79,7 +79,7 @@ Node::InsertionNotificationRequest TextControlElement::insertedInto(
if (!insertionPoint->isConnected())
return InsertionDone;
String initialValue = value();
- setTextAsOfLastFormControlChangeEvent(initialValue.isNull() ? emptyString()
+ setTextAsOfLastFormControlChangeEvent(initialValue.isNull() ? emptyString
: initialValue);
return InsertionDone;
}
@@ -773,7 +773,7 @@ String TextControlElement::innerEditorValue() const {
DCHECK(!openShadowRoot());
HTMLElement* innerEditor = innerEditorElement();
if (!innerEditor || !isTextControl())
- return emptyString();
+ return emptyString;
StringBuilder result;
for (Node& node : NodeTraversal::inclusiveDescendantsOf(*innerEditor)) {

Powered by Google App Engine
This is Rietveld 408576698