third_party/WebKit/Source/core/editing/serializers/Serialization.cpp - Issue 2668903003: Replace WTF::emptyString{16Bit}() with a static global

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/serializers/Serialization.cpp

Issue 2668903003: Replace WTF::emptyString{16Bit}() with a static global (Closed)

Patch Set: Replace WTF::emptyString{16Bit}() with a static global Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h ('k') | third_party/WebKit/Source/core/events/ApplicationCacheErrorEvent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/serializers/Serialization.cpp

diff --git a/third_party/WebKit/Source/core/editing/serializers/Serialization.cpp b/third_party/WebKit/Source/core/editing/serializers/Serialization.cpp

index c5d16388a126b1dcce635e01da7be270af75d289..9447499b7940d2471adcabfa4a3267dd7afd2db8 100644

--- a/third_party/WebKit/Source/core/editing/serializers/Serialization.cpp

+++ b/third_party/WebKit/Source/core/editing/serializers/Serialization.cpp

@@ -261,18 +261,18 @@ String CreateMarkupAlgorithm<Strategy>::createMarkup(

EAbsoluteURLs shouldResolveURLs,

Node* constrainingAncestor) {

if (startPosition.isNull() || endPosition.isNull())

- return emptyString();

+ return emptyString;

RELEASE_ASSERT(startPosition.compareTo(endPosition) <= 0);

bool collapsed = startPosition == endPosition;

if (collapsed)

- return emptyString();

+ return emptyString;

Node* commonAncestor =

Strategy::commonAncestor(*startPosition.computeContainerNode(),

*endPosition.computeContainerNode());

if (!commonAncestor)

- return emptyString();

+ return emptyString;

Document* document = startPosition.document();