Replace WTF::emptyString{16Bit}() with a static global

third_party/WebKit/Source/wtf/text/WTFString.cpp

 /*
  * (C) 1999 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2010, 2012 Apple Inc. All rights
  * reserved.
  * Copyright (C) 2007-2009 Torch Mobile, Inc.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 691 matching lines @@
         putUTF8Triple(buffer, *characters);
       }
     }
   }
 
   return CString(bufferVector.data(), buffer - bufferVector.data());
 }
 
 String String::make8BitFrom16BitSource(const UChar* source, size_t length) {
   if (!length)
-    return emptyString();
+    return emptyString;
 
   LChar* destination;
   String result = String::createUninitialized(length, destination);
 
   copyLCharsFromUCharSource(destination, source, length);
 
   return result;
 }
 
 String String::make16BitFrom8BitSource(const LChar* source, size_t length) {
   if (!length)
-    return emptyString16Bit();
+    return emptyString16Bit;
 
   UChar* destination;
   String result = String::createUninitialized(length, destination);
 
   StringImpl::copyChars(destination, source, length);
 
   return result;
 }
 
 String String::fromUTF8(const LChar* stringStart, size_t length) {
   RELEASE_ASSERT(length <= std::numeric_limits<unsigned>::max());
 
   if (!stringStart)
     return String();
 
   if (!length)
-    return emptyString();
+    return emptyString;
 
   if (charactersAreAllASCII(stringStart, length))
     return StringImpl::create(stringStart, length);
 
   Vector<UChar, 1024> buffer(length);
   UChar* bufferStart = buffer.data();
 
   UChar* bufferCurrent = bufferStart;
   const char* stringCurrent = reinterpret_cast<const char*>(stringStart);
   if (convertUTF8ToUTF16(
@@ skipping 16 matching lines @@
   return fromUTF8(s.data());
 }
 
 String String::fromUTF8WithLatin1Fallback(const LChar* string, size_t size) {
   String utf8 = fromUTF8(string, size);
   if (!utf8)
     return String(string, size);
   return utf8;
 }
 
-const String& emptyString() {
-  DEFINE_STATIC_LOCAL(String, emptyString, (StringImpl::empty));
-  return emptyString;
-}
-
-const String& emptyString16Bit() {
-  DEFINE_STATIC_LOCAL(String, emptyString, (StringImpl::empty16Bit));
-  return emptyString;
-}
-
 std::ostream& operator<<(std::ostream& out, const String& string) {
   if (string.isNull())
     return out << "<null>";
 
   out << '"';
   for (unsigned index = 0; index < string.length(); ++index) {
     // Print shorthands for select cases.
     UChar character = string[index];
     switch (character) {
       case '\t':
@@ skipping 29 matching lines @@
   return out << '"';
 }
 
 #ifndef NDEBUG
 void String::show() const {
   dataLogF("%s\n", asciiDebug(impl()).data());
 }
 #endif
 
 }  // namespace WTF