Replace WTF::emptyString{16Bit}() with a static global

third_party/WebKit/Source/platform/fonts/ScriptRunIteratorTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "platform/fonts/ScriptRunIterator.h"
 
 #include "testing/gtest/include/gtest/gtest.h"
 #include "wtf/Assertions.h"
 #include "wtf/Threading.h"
 #include "wtf/text/WTFString.h"
@@ skipping 91 matching lines @@
     for (int i = 0; i < 16; ++i) {
       if (kTable[i] == value) {
         return i;
       }
     }
     DLOG(ERROR) << "Table does not contain value 0x" << std::hex << value;
     return 0;
   }
 
   static String ToTestString(const std::string& input) {
-    String result(emptyString16Bit());
+    String result(emptyString16Bit);
     bool inSet = false;
     int seen = 0;
     int code = 0;
     int list = 0;
     int currentShift = 0;
     for (char c : input) {
       if (inSet) {
         switch (c) {
           case '(':
             ASSERT(seen == 0);
@@ skipping 158 matching lines @@
     kLatin3 + kGreek2 + kHan,
     kHan3 + kLatin2 + kGreek,
     kHan3 + kGreek2 + kLatin,
     kGreek3 + kLatin2 + kHan,
     kGreek3 + kHan2 + kLatin,
 };
 
 class ScriptRunIteratorTest : public testing::Test {
  protected:
   void CheckRuns(const Vector<TestRun>& runs) {
-    String text(emptyString16Bit());
+    String text(emptyString16Bit);
     Vector<ExpectedRun> expect;
     for (auto& run : runs) {
       text.append(String::fromUTF8(run.text.c_str()));
       expect.push_back(ExpectedRun(text.length(), run.code));
     }
     ScriptRunIterator scriptRunIterator(text.characters16(), text.length());
     VerifyRuns(&scriptRunIterator, expect);
   }
 
   // FIXME crbug.com/527329 - CheckMockRuns should be replaced by finding
   // suitable equivalent real codepoint sequences instead.
   void CheckMockRuns(const Vector<TestRun>& runs) {
-    String text(emptyString16Bit());
+    String text(emptyString16Bit);
     Vector<ExpectedRun> expect;
     for (const TestRun& run : runs) {
       text.append(MockScriptData::ToTestString(run.text));
       expect.push_back(ExpectedRun(text.length(), run.code));
     }
 
     ScriptRunIterator scriptRunIterator(text.characters16(), text.length(),
                                         MockScriptData::instance());
     VerifyRuns(&scriptRunIterator, expect);
   }
 
   void VerifyRuns(ScriptRunIterator* scriptRunIterator,
                   const Vector<ExpectedRun>& expect) {
     unsigned limit;
     UScriptCode code;
     unsigned long runCount = 0;
     while (scriptRunIterator->consume(limit, code)) {
       ASSERT_LT(runCount, expect.size());
       ASSERT_EQ(expect[runCount].limit, limit);
       ASSERT_EQ(expect[runCount].code, code);
       ++runCount;
     }
     ASSERT_EQ(expect.size(), runCount);
   }
 };
 
 TEST_F(ScriptRunIteratorTest, Empty) {
-  String empty(emptyString16Bit());
+  String empty(emptyString16Bit);
   ScriptRunIterator scriptRunIterator(empty.characters16(), empty.length());
   unsigned limit = 0;
   UScriptCode code = USCRIPT_INVALID_CODE;
   ASSERT(!scriptRunIterator.consume(limit, code));
   ASSERT_EQ(limit, 0u);
   ASSERT_EQ(code, USCRIPT_INVALID_CODE);
 }
 
 // Some of our compilers cannot initialize a vector from an array yet.
 #define DECLARE_RUNSVECTOR(...)                   \
@@ skipping 336 matching lines @@
     }
   }
 }
 
 // ZWJ is \u200D Cf (Format, other) and its script is inherited.  I'm going to
 // ignore this for now, as I think it shouldn't matter which run it ends up
 // in. HarfBuzz needs to be able to use it as context and shape each
 // neighboring character appropriately no matter what run it got assigned to.
 
 }  // namespace blink