Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.cpp

Issue 2668903003: Replace WTF::emptyString{16Bit}() with a static global (Closed)
Patch Set: Replace WTF::emptyString{16Bit}() with a static global Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/imagecapture/PhotoCapabilities.h" 5 #include "modules/imagecapture/PhotoCapabilities.h"
6 6
7 namespace blink { 7 namespace blink {
8 8
9 namespace { 9 namespace {
10 10
11 String meteringModeToString(media::mojom::blink::MeteringMode mode) { 11 String meteringModeToString(media::mojom::blink::MeteringMode mode) {
12 switch (mode) { 12 switch (mode) {
13 case media::mojom::blink::MeteringMode::NONE: 13 case media::mojom::blink::MeteringMode::NONE:
14 return "none"; 14 return "none";
15 case media::mojom::blink::MeteringMode::MANUAL: 15 case media::mojom::blink::MeteringMode::MANUAL:
16 return "manual"; 16 return "manual";
17 case media::mojom::blink::MeteringMode::SINGLE_SHOT: 17 case media::mojom::blink::MeteringMode::SINGLE_SHOT:
18 return "single-shot"; 18 return "single-shot";
19 case media::mojom::blink::MeteringMode::CONTINUOUS: 19 case media::mojom::blink::MeteringMode::CONTINUOUS:
20 return "continuous"; 20 return "continuous";
21 default: 21 default:
22 NOTREACHED(); 22 NOTREACHED();
23 } 23 }
24 return emptyString(); 24 return emptyString;
25 } 25 }
26 26
27 } // anonymous namespace 27 } // anonymous namespace
28 28
29 // static 29 // static
30 PhotoCapabilities* PhotoCapabilities::create() { 30 PhotoCapabilities* PhotoCapabilities::create() {
31 return new PhotoCapabilities(); 31 return new PhotoCapabilities();
32 } 32 }
33 33
34 String PhotoCapabilities::focusMode() const { 34 String PhotoCapabilities::focusMode() const {
(...skipping 16 matching lines...) Expand all
51 return "off"; 51 return "off";
52 case media::mojom::blink::FillLightMode::AUTO: 52 case media::mojom::blink::FillLightMode::AUTO:
53 return "auto"; 53 return "auto";
54 case media::mojom::blink::FillLightMode::FLASH: 54 case media::mojom::blink::FillLightMode::FLASH:
55 return "flash"; 55 return "flash";
56 case media::mojom::blink::FillLightMode::TORCH: 56 case media::mojom::blink::FillLightMode::TORCH:
57 return "torch"; 57 return "torch";
58 default: 58 default:
59 NOTREACHED(); 59 NOTREACHED();
60 } 60 }
61 return emptyString(); 61 return emptyString;
62 } 62 }
63 63
64 DEFINE_TRACE(PhotoCapabilities) { 64 DEFINE_TRACE(PhotoCapabilities) {
65 visitor->trace(m_iso); 65 visitor->trace(m_iso);
66 visitor->trace(m_imageHeight); 66 visitor->trace(m_imageHeight);
67 visitor->trace(m_imageWidth); 67 visitor->trace(m_imageWidth);
68 visitor->trace(m_zoom); 68 visitor->trace(m_zoom);
69 visitor->trace(m_exposureCompensation); 69 visitor->trace(m_exposureCompensation);
70 visitor->trace(m_colorTemperature); 70 visitor->trace(m_colorTemperature);
71 visitor->trace(m_brightness); 71 visitor->trace(m_brightness);
72 visitor->trace(m_contrast); 72 visitor->trace(m_contrast);
73 visitor->trace(m_saturation); 73 visitor->trace(m_saturation);
74 visitor->trace(m_sharpness); 74 visitor->trace(m_sharpness);
75 } 75 }
76 76
77 } // namespace blink 77 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698