third_party/WebKit/Source/modules/app_banner/AppBannerController.cpp - Issue 2668903003: Replace WTF::emptyString{16Bit}() with a static global

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/app_banner/AppBannerController.cpp

Issue 2668903003: Replace WTF::emptyString{16Bit}() with a static global (Closed)

Patch Set: Replace WTF::emptyString{16Bit}() with a static global Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/core/xml/XSLStyleSheet.h ('k') | third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "modules/app_banner/AppBannerController.h"	5 #include "modules/app_banner/AppBannerController.h"

6	6

7 #include "core/EventTypeNames.h"	7 #include "core/EventTypeNames.h"

8 #include "core/dom/Document.h"	8 #include "core/dom/Document.h"

9 #include "core/frame/DOMWindow.h"	9 #include "core/frame/DOMWindow.h"

10 #include "core/frame/LocalFrame.h"	10 #include "core/frame/LocalFrame.h"

(...skipping 36 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
47 std::move(eventRequest), platforms)) ==	47 std::move(eventRequest), platforms)) ==

48 DispatchEventResult::NotCanceled	48 DispatchEventResult::NotCanceled

49 ? mojom::AppBannerPromptReply::NONE	49 ? mojom::AppBannerPromptReply::NONE

50 : mojom::AppBannerPromptReply::CANCEL;	50 : mojom::AppBannerPromptReply::CANCEL;

51	51

52 AtomicString referrer = SecurityPolicy::generateReferrer(	52 AtomicString referrer = SecurityPolicy::generateReferrer(

53 m_frame->document()->getReferrerPolicy(), KURL(),	53 m_frame->document()->getReferrerPolicy(), KURL(),

54 m_frame->document()->outgoingReferrer())	54 m_frame->document()->outgoingReferrer())

55 .referrer;	55 .referrer;

56	56

57 callback.Run(reply, referrer.isNull() ? emptyString() : referrer);	57 callback.Run(reply, referrer.isNull() ? emptyString : referrer);

58 }	58 }

59	59

60 } // namespace blink	60 } // namespace blink

OLD	NEW