Replace WTF::emptyString{16Bit}() with a static global

third_party/WebKit/Source/core/css/StylePropertySerializer.cpp

 /*
  * (C) 1999-2003 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All
  * rights reserved.
  * Copyright (C) 2011 Research In Motion Limited. All rights reserved.
  * Copyright (C) 2013 Intel Corporation. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 333 matching lines @@
   int longhandCount = shorthand.length();
   DCHECK_LE(longhandCount, 17);
   const CSSValue* longhands[17] = {};
 
   bool hasImportant = false;
   bool hasNonImportant = false;
 
   for (int i = 0; i < longhandCount; i++) {
     int index = m_propertySet.findPropertyIndex(shorthand.properties()[i]);
     if (index == -1)
-      return emptyString();
+      return emptyString;
     PropertyValueForSerializer value = m_propertySet.propertyAt(index);
 
     hasImportant |= value.isImportant();
     hasNonImportant |= !value.isImportant();
     longhands[i] = value.value();
   }
 
   if (hasImportant && hasNonImportant)
-    return emptyString();
+    return emptyString;
 
   if (longhands[0]->isCSSWideKeyword() ||
       longhands[0]->isPendingSubstitutionValue()) {
     bool success = true;
     for (int i = 1; i < longhandCount; i++) {
       if (!longhands[i]->equals(*longhands[0])) {
-        // This should just return emptyString() but some shorthands currently
+        // This should just return emptyString but some shorthands currently
         // allow 'initial' for their longhands.
         success = false;
         break;
       }
     }
     if (success) {
       if (longhands[0]->isPendingSubstitutionValue())
         return toCSSPendingSubstitutionValue(longhands[0])
             ->shorthandValue()
             ->cssText();
       return longhands[0]->cssText();
     }
   }
 
   bool allowInitial = allowInitialInShorthand(shorthand.id());
   for (int i = 0; i < longhandCount; i++) {
     const CSSValue& value = *longhands[i];
     if (!allowInitial && value.isInitialValue())
-      return emptyString();
+      return emptyString;
     if (value.isInheritedValue() || value.isUnsetValue() ||
         value.isPendingSubstitutionValue())
-      return emptyString();
+      return emptyString;
     if (value.isVariableReferenceValue())
-      return emptyString();
+      return emptyString;
   }
 
   return String();
 }
 
 String StylePropertySerializer::getPropertyValue(
     CSSPropertyID propertyID) const {
   const StylePropertyShorthand& shorthand = shorthandForProperty(propertyID);
   // TODO(timloh): This is weird, why do we call this with non-shorthands at
   // all?
@@ skipping 188 matching lines @@
   // Check that non-initial font-variant subproperties are not conflicting with
   // this serialization.
   const CSSValue* ligaturesValue = fontVariantLigaturesProperty.value();
   const CSSValue* numericValue = fontVariantNumericProperty.value();
   if ((ligaturesValue->isIdentifierValue() &&
        toCSSIdentifierValue(ligaturesValue)->getValueID() != CSSValueNormal) ||
       ligaturesValue->isValueList() ||
       (numericValue->isIdentifierValue() &&
        toCSSIdentifierValue(numericValue)->getValueID() != CSSValueNormal) ||
       numericValue->isValueList())
-    return emptyString();
+    return emptyString;
 
   StringBuilder result;
   appendFontLonghandValueIfNotNormal(CSSPropertyFontStyle, result);
 
   const CSSValue* val = fontVariantCapsProperty.value();
   if (val->isIdentifierValue() &&
       (toCSSIdentifierValue(val)->getValueID() != CSSValueSmallCaps &&
        toCSSIdentifierValue(val)->getValueID() != CSSValueNormal))
-    return emptyString();
+    return emptyString;
   appendFontLonghandValueIfNotNormal(CSSPropertyFontVariantCaps, result);
 
   appendFontLonghandValueIfNotNormal(CSSPropertyFontWeight, result);
   appendFontLonghandValueIfNotNormal(CSSPropertyFontStretch, result);
   if (!result.isEmpty())
     result.append(' ');
   result.append(fontSizeProperty.value()->cssText());
   appendFontLonghandValueIfNotNormal(CSSPropertyLineHeight, result);
   if (!result.isEmpty())
     result.append(' ');
@@ skipping 304 matching lines @@
     const CSSValue& xValue =
         repeatXList ? repeatXList->item(i % repeatXList->length()) : repeatX;
     const CSSValue& yValue =
         repeatYList ? repeatYList->item(i % repeatYList->length()) : repeatY;
     appendBackgroundRepeatValue(builder, xValue, yValue);
   }
   return builder.toString();
 }
 
 }  // namespace blink