Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2668893004: VM: [Kernel] Add --embedder-entry-points-manifest to dartk/transform and pass it to the treeshaker (Closed)

Created:
3 years, 10 months ago by kustermann
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: [Kernel] Add --embedder-entry-points-manifest to dartk/transform and pass it to the treeshaker The VM's gen_snapshot already accepts an --embedder-entry-points-manifest option. This CL makes dartk/transform.dart accept the same option and pass the roots on to the treeshaker. In addition to what gen_snapshot accepts, we also accept "*external-instantiation*" instead of a specific constructor/factory name) BUG=https://github.com/dart-lang/sdk/issues/28559 R=asgerf@google.com, vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/2e4849856ad17ff0c8b5b7757027b8fbda468b25

Patch Set 1 #

Patch Set 2 : Add missing bin/util.dart #

Unified diffs Side-by-side diffs Delta from patch set Stats (+249 lines, -14 lines) Patch
M pkg/kernel/bin/dartk.dart View 4 chunks +13 lines, -1 line 0 comments Download
M pkg/kernel/bin/transform.dart View 4 chunks +12 lines, -1 line 0 comments Download
A pkg/kernel/bin/util.dart View 1 1 chunk +68 lines, -0 lines 0 comments Download
M pkg/kernel/lib/target/targets.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/kernel/lib/target/vm.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/kernel/lib/transformations/treeshaker.dart View 9 chunks +148 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
kustermann
3 years, 10 months ago (2017-02-01 15:53:43 UTC) #2
asgerf
LGTM I'm hoping we can clean up the searching code when canonical names land.
3 years, 10 months ago (2017-02-02 14:19:49 UTC) #4
Vyacheslav Egorov (Google)
lgtm
3 years, 10 months ago (2017-02-02 14:26:32 UTC) #5
kustermann
3 years, 10 months ago (2017-02-03 11:14:42 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
2e4849856ad17ff0c8b5b7757027b8fbda468b25 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698