Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: pkg/kernel/lib/frontend/accessors.dart

Issue 2668893003: Kernel: Do not try to use return value of []= (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/kernel/lib/frontend/accessors.dart
diff --git a/pkg/kernel/lib/frontend/accessors.dart b/pkg/kernel/lib/frontend/accessors.dart
index 48bb2c5ce84c56a0d049a4ff66d71a7cae63c0ae..ce098c3c6efdbdf6c8f7f2d92f40cdde00f8222e 100644
--- a/pkg/kernel/lib/frontend/accessors.dart
+++ b/pkg/kernel/lib/frontend/accessors.dart
@@ -32,13 +32,13 @@ abstract class Accessor {
{bool voidContext: false}) {
if (voidContext) {
return _finish(new ConditionalExpression(buildIsNull(_makeRead()),
- _makeWrite(value, voidContext), new NullLiteral(), type));
+ _makeWrite(value, false), new NullLiteral(), type));
}
var tmp = new VariableDeclaration.forValue(_makeRead());
return _finish(makeLet(
tmp,
new ConditionalExpression(buildIsNull(new VariableGet(tmp)),
- _makeWrite(value, voidContext), new VariableGet(tmp), type)));
+ _makeWrite(value, false), new VariableGet(tmp), type)));
}
Expression buildCompoundAssignment(Name binaryOperator, Expression value,

Powered by Google App Engine
This is Rietveld 408576698