chrome/browser/tab_contents/navigation_metrics_recorder.h - Issue 2668883002: Convert NavigationMetricsRecorder to use the new navigation callbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/tab_contents/navigation_metrics_recorder.h

Issue 2668883002: Convert NavigationMetricsRecorder to use the new navigation callbacks. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/tab_contents/navigation_metrics_recorder.h

diff --git a/chrome/browser/tab_contents/navigation_metrics_recorder.h b/chrome/browser/tab_contents/navigation_metrics_recorder.h

index a13bba98c02da6efa9d947918eb85eaaad965af2..4dc18c84d2dbe7026ca1462f4f0ef6ad4602306b 100644

--- a/chrome/browser/tab_contents/navigation_metrics_recorder.h

+++ b/chrome/browser/tab_contents/navigation_metrics_recorder.h

@@ -38,9 +38,8 @@ class NavigationMetricsRecorder

friend class content::WebContentsUserData<NavigationMetricsRecorder>;

// content::WebContentsObserver overrides:

- void DidNavigateMainFrame(

- const content::LoadCommittedDetails& details,

- const content::FrameNavigateParams& params) override;

+ void DidFinishNavigation(

+ content::NavigationHandle* navigation_handle) override;

rappor::RapporServiceImpl* rappor_service_;