cc/playback/image_id.h - Issue 2668873002: cc: Add checker-imaging support to TileManager.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: cc/playback/image_id.h

Issue 2668873002: cc: Add checker-imaging support to TileManager. (Closed)

Patch Set: all tests Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2017 The Chromium Authors. All rights reserved.	1 // Copyright 2017 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CC_PLAYBACK_IMAGE_ID_H_	5 #ifndef CC_PLAYBACK_IMAGE_ID_H_

6 #define CC_PLAYBACK_IMAGE_ID_H_	6 #define CC_PLAYBACK_IMAGE_ID_H_

7	7

	8 #include <stdint.h>

	9 #include <unordered_set>

	10

	11 #include "base/containers/flat_set.h"

	12

8 namespace cc {	13 namespace cc {

9	14

10 using ImageId = uint32_t;	15 using ImageId = uint32_t;

	16 using ImageIdSet = std::unordered_set<ImageId>;

	17 using ImageIdFlatSet = base::flat_set<ImageId>;
	vmpstr 2017/02/13 22:49:30 I don't really like that we have both an unordered I don't really like that we have both an unordered set and a flat set. Especially since we have to name the typedef as ImageIdFlatSet, which needlessly reveals the underlying type. Remind me, why do we need ImageIdSet? Can we just keep the flat_set version and name it ImageIdSet? Khushal 2017/02/14 05:10:22 We were using the unordered_set for the internal s Show quoted text On 2017/02/13 22:49:30, vmpstr wrote: > I don't really like that we have both an unordered set and a flat set. > Especially since we have to name the typedef as ImageIdFlatSet, which needlessly > reveals the underlying type. Remind me, why do we need ImageIdSet? Can we just > keep the flat_set version and name it ImageIdSet? We were using the unordered_set for the internal state in the tracker, like the once decoded images set, where using a flat set will become sub-optimal.
11	18

12 } // namespace cc	19 } // namespace cc

13	20

14 #endif // CC_PLAYBACK_IMAGE_ID_H_	21 #endif // CC_PLAYBACK_IMAGE_ID_H_

OLD	NEW

« cc/layers/picture_layer_impl.cc ('K') | « cc/playback/image_hijack_canvas_unittest.cc ('k') | cc/playback/raster_source.h » ('j') | cc/tiles/checker_image_tracker.h » ('J')