Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9735)

Unified Diff: components/content_settings/core/common/content_settings_types.h

Issue 2668833003: DialogBrowserTest implementation to invoke Content settings bubble dialogs. (Closed)
Patch Set: Fixed nits and added enum element per recommendation. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/content_settings/core/common/content_settings_types.h
diff --git a/components/content_settings/core/common/content_settings_types.h b/components/content_settings/core/common/content_settings_types.h
index dd251805002ef2c3ba57a98abb79b64b660dfaf2..e77097cef43aa5f197d3fee27034960b5a56a31a 100644
--- a/components/content_settings/core/common/content_settings_types.h
+++ b/components/content_settings/core/common/content_settings_types.h
@@ -47,6 +47,13 @@ enum ContentSettingsType {
CONTENT_SETTINGS_TYPE_IMPORTANT_SITE_INFO,
CONTENT_SETTINGS_TYPE_PERMISSION_AUTOBLOCKER_DATA,
CONTENT_SETTINGS_TYPE_SUBRESOURCE_FILTER,
+ // This enum element is used in
+ // chrome/browser/ui/content_setting_image_model.cc for establishing
+ // the order of the content setting icons within the OmniBox. It is also
+ // used in chrome/browser/ui/views/location_bar/
+ // content_setting_bubble_dialog_browsertest.cc to invoke the icon's
+ // associated bubble dialog for testing purposes.
+ CONTENT_SETTINGS_TYPE_DECEPTIVE_CONTENT,
// WARNING: This enum is going to be removed soon. Do not depend on NUM_TYPES.
CONTENT_SETTINGS_NUM_TYPES_DO_NOT_USE,
« chrome/browser/ui/content_settings/content_setting_image_model.cc ('K') | « chrome/test/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698