Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5220)

Unified Diff: chrome/browser/ui/test/browser_dialog_browsertest.cc

Issue 2668833003: DialogBrowserTest implementation to invoke Content settings bubble dialogs. (Closed)
Patch Set: Updates from feedback Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/test/browser_dialog_browsertest.cc
diff --git a/chrome/browser/ui/test/browser_dialog_browsertest.cc b/chrome/browser/ui/test/browser_dialog_browsertest.cc
index 2c769d3b28b6081501ef2d977d440cf41e9a9cd4..a0884053193f8d3c51dc38da9573d94f9cb906ba 100644
--- a/chrome/browser/ui/test/browser_dialog_browsertest.cc
+++ b/chrome/browser/ui/test/browser_dialog_browsertest.cc
@@ -8,6 +8,7 @@
#include "base/test/test_switches.h"
#include "base/test/test_timeouts.h"
#include "chrome/browser/ui/test/test_browser_dialog.h"
+#include "content/public/common/content_switches.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/compositor/compositor_switches.h"
@@ -66,6 +67,13 @@ TEST(BrowserDialogTest, Invoke) {
command.AppendSwitchASCII(switches::kTestLauncherTimeout,
TestTimeouts::kNoTimeoutSwitchValue);
command.AppendSwitch(switches::kEnablePixelOutputInTests);
+#if defined(OS_WIN)
+ // Under Windows, dialogs (but not the browser window) created in the
+ // spawned browser_test process are invisible for some unknown reason.
+ // Pass in --disable-gpu to resolve this for now. See
+ // http://crbug.com/687387.
Peter Kasting 2017/02/08 01:00:03 Check my last comment on that bug to ensure this i
kylix_rd 2017/02/10 22:47:48 There is another issue that bsep@ will also be add
+ command.AppendSwitch(switches::kDisableGpu);
+#endif
} else {
options.wait = true;
}

Powered by Google App Engine
This is Rietveld 408576698