DialogBrowserTest implementation to invoke Content settings bubble dialogs.

chrome/browser/ui/views/location_bar/location_bar_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/location_bar/location_bar_view.h"
 
 #include <algorithm>
 #include <map>
 
 #include "base/i18n/rtl.h"
@@ skipping 1079 matching lines @@
   }
 
   NOTREACHED();
 }
 
 bool LocationBarView::GetBookmarkStarVisibility() {
   DCHECK(star_view_);
   return star_view_->visible();
 }
 
+int LocationBarView::ContentSettingImageModelCount() {
+  return content_setting_views_.size();

[Peter Kasting, 2017/02/06 21:14:25]

This is a size_t, so the function should return a size_t (and callers of it
should store the results in a size_t, etc.)

+}
+
+ContentSettingImageModel* LocationBarView::GetContentSettingImageModel(
+    size_t index) {
+  DCHECK_LT(index, content_setting_views_.size());
+  return content_setting_views_.at(index)->content_setting_image_model();

[Peter Kasting, 2017/02/06 21:14:25]

Nit: At least in location_bar code, don't use at().  Use [].  (See my previous
drive-by comments; I don't speak for what Mac wants to do, but I'd rather not
use at() here.)

+}
+
 ////////////////////////////////////////////////////////////////////////////////
 // LocationBarView, private views::View implementation:
 
 const char* LocationBarView::GetClassName() const {
   return kViewClassName;
 }
 
 void LocationBarView::OnBoundsChanged(const gfx::Rect& previous_bounds) {
   OmniboxPopupView* popup = omnibox_view_->model()->popup_model()->view();
   if (popup->IsOpen())
@@ skipping 101 matching lines @@
 // LocationBarView, private TemplateURLServiceObserver implementation:
 
 void LocationBarView::OnTemplateURLServiceChanged() {
   template_url_service_->RemoveObserver(this);
   template_url_service_ = nullptr;
   // If the browser is no longer active, let's not show the info bubble, as this
   // would make the browser the active window again.
   if (omnibox_view_ && omnibox_view_->GetWidget()->IsActive())
     ShowFirstRunBubble();
 }
+
+////////////////////////////////////////////////////////////////////////////////
+// LocationBarView, private function(s) for testing:
+
+ContentSettingImageView*
+LocationBarView::GetContentSettingImageViewFromImageModel(
+    ContentSettingImageModel* image_model) {
+  for (auto view : content_setting_views_) {

[tapted, 2017/02/03 23:07:03]

The guide says we can use auto for "cases where the type doesn't aid in clarity
for the reader." - I don't think that's the case here when compared to
ContentSettingImageView*

(also seeing raw `auto` without `auto*` or `const auto&` also means we have to
question whether we are invoking the copy constructor by accident, but that's
orthogonal).

See http://go/cppguide#auto

[Peter Kasting, 2017/02/06 21:14:25]

I would use [const] auto* here, personally.  I agree that auto* is better than
auto, but I think auto* is sufficiently clear here and we don't really need
ContentSettingImageView*.  That said, I don't care much; I am OK with either
route.

+    if (view->content_setting_image_model() == image_model)
+      return view;
+  }
+  NOTREACHED();
+  return nullptr;
+}
+
+