DialogBrowserTest implementation to invoke Content settings bubble dialogs.

chrome/browser/ui/views/location_bar/content_setting_image_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_CONTENT_SETTING_IMAGE_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_CONTENT_SETTING_IMAGE_VIEW_H_
 
 #include <memory>
 
 #include "base/macros.h"
 #include "chrome/browser/ui/content_settings/content_setting_image_model.h"
 #include "chrome/browser/ui/views/location_bar/icon_label_bubble_view.h"
 #include "components/content_settings/core/common/content_settings_types.h"
 #include "ui/gfx/animation/animation_delegate.h"
 #include "ui/gfx/animation/slide_animation.h"
 #include "ui/views/painter.h"
 #include "ui/views/view.h"
 #include "ui/views/widget/widget_observer.h"
 
 class ContentSettingImageModel;
 class LocationBarView;
+class ContentSettingBubbleDialogTest;

[tapted, 2017/02/03 00:35:40]

nit: sort  (but, also, since they share a namespace, I don't think this forward
declare is necessary -- declaring the friend will implicitly forward-declare the
class, so I think we can just remove this)

- same for location_bar_view.h

[kylix_rd, 2017/02/03 18:55:04]

Done.

 
 namespace content {
 class WebContents;
 }
 
 namespace gfx {
 class FontList;
 }
 
 namespace views {
 class BubbleDialogDelegateView;
 }
 
 // The ContentSettingImageView displays an icon and optional text label for
 // various content settings affordances in the location bar (i.e. plugin
 // blocking, geolocation).
 class ContentSettingImageView : public IconLabelBubbleView,
                                 public gfx::AnimationDelegate,
                                 public views::WidgetObserver {
  public:
   ContentSettingImageView(std::unique_ptr<ContentSettingImageModel> image_model,
                           LocationBarView* parent,
                           const gfx::FontList& font_list);
   ~ContentSettingImageView() override;
 
   // Updates the decoration from the shown WebContents.
   void Update(content::WebContents* web_contents);
 
+  // For testing. Return this view's ContentSettingImageModel.
+  ContentSettingImageModel* content_setting_image_model() {
+    return content_setting_image_model_.get();
+  }
+
  private:
+  friend class ContentSettingBubbleDialogTest;
+
   // The total animation time, including open and close as well as an
   // intervening "stay open" period.
   static const int kAnimationDurationMS;
 
   // IconLabelBubbleView:
   const char* GetClassName() const override;
   void OnBoundsChanged(const gfx::Rect& previous_bounds) override;
   bool OnMousePressed(const ui::MouseEvent& event) override;
   void OnMouseReleased(const ui::MouseEvent& event) override;
   void OnGestureEvent(ui::GestureEvent* event) override;
@@ skipping 12 matching lines @@
   void AnimationProgressed(const gfx::Animation* animation) override;
   void AnimationCanceled(const gfx::Animation* animation) override;
 
   // views::WidgetObserver:
   void OnWidgetDestroying(views::Widget* widget) override;
   void OnWidgetVisibilityChanged(views::Widget* widget, bool visible) override;
 
   // Updates the image and tooltip to match the current model state.
   void UpdateImage();
 
+  // Return the currently active bubble dialog. Used for testing.
+  views::BubbleDialogDelegateView* bubble_view() {

[tapted, 2017/02/03 00:35:40]

This shouldn't be necessary here (a private accessor function is kinda odd) --
the test harness can just do image_view->bubble_view_ instead of
image_view->bubble_view()

[kylix_rd, 2017/02/03 18:55:04]

I figured that with the inline method, it would collapse to just
'image_view->bubble_view_' while having a place to explicitly place a comment
that it's being accessed by a test.

[tapted, 2017/02/03 23:07:02]

This violates
https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md...

+    return bubble_view_;
+  }
+
   LocationBarView* parent_;  // Weak, owns us.
   std::unique_ptr<ContentSettingImageModel> content_setting_image_model_;
   gfx::SlideAnimation slide_animator_;
   bool pause_animation_;
   double pause_animation_state_;
   views::BubbleDialogDelegateView* bubble_view_;
 
   // This is used to check if the bubble was showing during the mouse pressed
   // event. If this is true then the mouse released event is ignored to prevent
   // the bubble from reshowing.
   bool suppress_mouse_released_action_;
 
   DISALLOW_COPY_AND_ASSIGN(ContentSettingImageView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_CONTENT_SETTING_IMAGE_VIEW_H_