Issue 266883011: Temporarily disable NEON on Android framework builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 266883011: Temporarily disable NEON on Android framework builds. (Closed)

Created:
6 years, 7 months ago by djsollen

Modified:
6 years, 7 months ago

Reviewers:
scroggo

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Temporarily disable NEON on Android framework builds. The GCC 4.8 compiler has an AARCH64 bug that generated non-PIC output that fails to link. R=scroggo@google.com Committed: https://code.google.com/p/skia/source/detail?r=14597

Patch Set 1 #

Total comments: 1

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	gyp/opts.gyp	View		2 chunks	+3 lines, -2 lines	1 comment	Download
	M	src/core/SkUtilsArm.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scroggo

lgtm https://codereview.chromium.org/266883011/diff/1/gyp/opts.gyp File gyp/opts.gyp (right): https://codereview.chromium.org/266883011/diff/1/gyp/opts.gyp#newcode107 gyp/opts.gyp:107: or (skia_android_framework and skia_arch_type == "arm64")', { For ...

6 years, 7 months ago (2014-05-06 19:07:11 UTC) #2

djsollen

6 years, 7 months ago (2014-05-06 19:47:11 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r14597 (presubmit successful).

Expand Messages | Collapse Messages