Add a reason for configuring DTM for backup/rollback. In backup/rollback,

Add a reason for configuring DTM for backup/rollback. In backup/rollback,
only add control types in addtional to user selectable types.

BUG=362679
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269612

[Nicolas Zea, 2014-05-06 18:55:33]

Add a DTM test for this?

[Nicolas Zea, 2014-05-06 18:58:51]

https://codereview.chromium.org/266883007/diff/1/chrome/browser/sync/glue/dat...
File chrome/browser/sync/glue/data_type_manager_impl.cc (right):

https://codereview.chromium.org/266883007/diff/1/chrome/browser/sync/glue/dat...
chrome/browser/sync/glue/data_type_manager_impl.cc:81:
desired_types.PutAll(syncer::ControlTypes());
Do we need the control types when backing up?

[haitaol1, 2014-05-06 20:53:30]

https://codereview.chromium.org/266883007/diff/1/chrome/browser/sync/glue/dat...
File chrome/browser/sync/glue/data_type_manager_impl.cc (right):

https://codereview.chromium.org/266883007/diff/1/chrome/browser/sync/glue/dat...
chrome/browser/sync/glue/data_type_manager_impl.cc:81:
desired_types.PutAll(syncer::ControlTypes());
On 2014/05/06 18:58:51, Nicolas Zea wrote:
> Do we need the control types when backing up?

It's not needed for backup. This is to get around SyncBackendHost, which stops
if not all control types are initialized.

[Nicolas Zea, 2014-05-07 17:12:17]

I see. May as well add a basic unit test for that then.

[haitaol1, 2014-05-07 20:46:07]

On 2014/05/07 17:12:17, Nicolas Zea wrote:
> I see. May as well add a basic unit test for that then.

Added DTM unit test.

[Nicolas Zea, 2014-05-07 20:52:00]

lgtm

[haitaol1, 2014-05-09 17:15:35]

The CQ bit was checked by haitaol@chromium.org

[commit-bot: I haz the power, 2014-05-09 17:20:41]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/haitaol@chromium.org/266883007/20001

[commit-bot: I haz the power, 2014-05-10 19:09:47]

Change committed as 269612