Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1080)

Unified Diff: media/base/media.cc

Issue 2668813002: Remove LazyInstance usage from media/ (Closed)
Patch Set: Fix presubmit comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/key_systems.cc ('k') | media/base/mime_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/media.cc
diff --git a/media/base/media.cc b/media/base/media.cc
index 8e9e719a70ce454bbee4c729a8ad790763107c6b..01b1d914b1a062d7bced19ff3e0451d8a5f5dac4 100644
--- a/media/base/media.cc
+++ b/media/base/media.cc
@@ -5,7 +5,6 @@
#include "media/base/media.h"
#include "base/command_line.h"
-#include "base/lazy_instance.h"
#include "base/macros.h"
#include "base/metrics/field_trial.h"
#include "base/trace_event/trace_event.h"
@@ -23,18 +22,9 @@
namespace media {
-// Media must only be initialized once, so use a LazyInstance to ensure this.
+// Media must only be initialized once; use a thread-safe static to do this.
class MediaInitializer {
public:
- void enable_platform_decoder_support() {
- has_platform_decoder_support_ = true;
- }
-
- bool has_platform_decoder_support() { return has_platform_decoder_support_; }
-
- private:
- friend struct base::DefaultLazyInstanceTraits<MediaInitializer>;
-
MediaInitializer() {
TRACE_EVENT_WARMUP_CATEGORY("audio");
TRACE_EVENT_WARMUP_CATEGORY("media");
@@ -58,34 +48,47 @@ class MediaInitializer {
#endif // !defined(MEDIA_DISABLE_FFMPEG)
}
- ~MediaInitializer() {
- NOTREACHED() << "MediaInitializer should be leaky!";
+#if defined(OS_ANDROID)
+ void enable_platform_decoder_support() {
+ has_platform_decoder_support_ = true;
+ }
+
+ bool has_platform_decoder_support() const {
+ return has_platform_decoder_support_;
}
+#endif // defined(OS_ANDROID)
+
+ private:
+ ~MediaInitializer() = delete;
+#if defined(OS_ANDROID)
bool has_platform_decoder_support_ = false;
+#endif // defined(OS_ANDROID)
DISALLOW_COPY_AND_ASSIGN(MediaInitializer);
};
-static base::LazyInstance<MediaInitializer>::Leaky g_media_library =
- LAZY_INSTANCE_INITIALIZER;
+static MediaInitializer* GetMediaInstance() {
+ static MediaInitializer* instance = new MediaInitializer();
+ return instance;
+}
void InitializeMediaLibrary() {
- g_media_library.Get();
+ GetMediaInstance();
}
#if defined(OS_ANDROID)
void EnablePlatformDecoderSupport() {
- g_media_library.Pointer()->enable_platform_decoder_support();
+ GetMediaInstance()->enable_platform_decoder_support();
}
bool HasPlatformDecoderSupport() {
- return g_media_library.Pointer()->has_platform_decoder_support();
+ return GetMediaInstance()->has_platform_decoder_support();
}
bool PlatformHasOpusSupport() {
return base::android::BuildInfo::GetInstance()->sdk_int() >= 21;
}
-#endif
+#endif // defined(OS_ANDROID)
} // namespace media
« no previous file with comments | « media/base/key_systems.cc ('k') | media/base/mime_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698