Chromium Code Reviews| Index: components/breakpad/tools/crash_service.h |
| diff --git a/chrome/tools/crash_service/crash_service.h b/components/breakpad/tools/crash_service.h |
| similarity index 87% |
| rename from chrome/tools/crash_service/crash_service.h |
| rename to components/breakpad/tools/crash_service.h |
| index 9ea56c576ad3308323b49b7413844c8f8703dc35..947361c9c121969a000bb40dbf7ebfa23405c26d 100644 |
| --- a/chrome/tools/crash_service/crash_service.h |
| +++ b/components/breakpad/tools/crash_service.h |
| @@ -2,8 +2,8 @@ |
| // Use of this source code is governed by a BSD-style license that can be |
| // found in the LICENSE file. |
| -#ifndef CHROME_TOOLS_CRASH_SERVICE_CRASH_SERVICE_H_ |
| -#define CHROME_TOOLS_CRASH_SERVICE_CRASH_SERVICE_H_ |
| +#ifndef COMPONENTS_BREAKPAD_TOOLS_CRASH_SERVICE_H_ |
| +#define COMPONENTS_BREAKPAD_TOOLS_CRASH_SERVICE_H_ |
| #include <string> |
| @@ -19,6 +19,8 @@ class ClientInfo; |
| } |
| +namespace breakpad { |
| + |
| // This class implements an out-of-process crash server. It uses breakpad's |
| // CrashGenerationServer and CrashReportSender to generate and then send the |
| // crash dumps. Internally, it uses OS specific pipe to allow applications to |
| @@ -28,15 +30,14 @@ class ClientInfo; |
| // possibly sent to the crash2 servers. |
| class CrashService { |
| public: |
| - // The ctor takes a directory that needs to be writable and will create |
| - // a subdirectory inside to keep logs, crashes and checkpoint files. |
| - explicit CrashService(const std::wstring& report_dir); |
| + explicit CrashService(); |
|
Robert Sesek
2013/10/17 13:16:05
No |explicit|
jochen (gone - plz use gerrit)
2013/10/17 16:47:39
Done.
|
| ~CrashService(); |
| - // Starts servicing crash dumps. The command_line specifies various behaviors, |
| - // see below for more information. Returns false if it failed. Do not use |
| + // Starts servicing crash dumps. Returns false if it failed. Do not use |
| // other members in that case. |
| - bool Initialize(const std::wstring& command_line); |
| + bool Initialize(const base::FilePath& operations_dir, |
|
Robert Sesek
2013/10/17 13:16:05
I don't know what an |operations_dir| is… comment?
jochen (gone - plz use gerrit)
2013/10/17 16:47:39
Done.
|
| + const base::FilePath& report_path, |
| + const base::FilePath& dumps_path); |
| // Command line switches: |
| // |
| @@ -120,4 +121,6 @@ class CrashService { |
| DISALLOW_COPY_AND_ASSIGN(CrashService); |
| }; |
| -#endif // CHROME_TOOLS_CRASH_SERVICE_CRASH_SERVICE_H_ |
| +} // namespace breakpad |
| + |
| +#endif // COMPONENTS_BREAKPAD_TOOLS_CRASH_SERVICE_H_ |