Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: components/breakpad/tools/crash_service.h

Issue 26688006: Move CrashService class to breakpad component (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: updates Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/breakpad/tools/crash_service.h
diff --git a/chrome/tools/crash_service/crash_service.h b/components/breakpad/tools/crash_service.h
similarity index 86%
rename from chrome/tools/crash_service/crash_service.h
rename to components/breakpad/tools/crash_service.h
index 9ea56c576ad3308323b49b7413844c8f8703dc35..3ce98025210802065dd8fb297f8f07520333eb60 100644
--- a/chrome/tools/crash_service/crash_service.h
+++ b/components/breakpad/tools/crash_service.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_TOOLS_CRASH_SERVICE_CRASH_SERVICE_H_
-#define CHROME_TOOLS_CRASH_SERVICE_CRASH_SERVICE_H_
+#ifndef COMPONENTS_BREAKPAD_TOOLS_CRASH_SERVICE_H_
+#define COMPONENTS_BREAKPAD_TOOLS_CRASH_SERVICE_H_
#include <string>
@@ -19,6 +19,8 @@ class ClientInfo;
}
+namespace breakpad {
+
// This class implements an out-of-process crash server. It uses breakpad's
// CrashGenerationServer and CrashReportSender to generate and then send the
// crash dumps. Internally, it uses OS specific pipe to allow applications to
@@ -28,15 +30,15 @@ class ClientInfo;
// possibly sent to the crash2 servers.
class CrashService {
public:
- // The ctor takes a directory that needs to be writable and will create
- // a subdirectory inside to keep logs, crashes and checkpoint files.
- explicit CrashService(const std::wstring& report_dir);
+ CrashService();
~CrashService();
- // Starts servicing crash dumps. The command_line specifies various behaviors,
- // see below for more information. Returns false if it failed. Do not use
- // other members in that case.
- bool Initialize(const std::wstring& command_line);
+ // Starts servicing crash dumps. Returns false if it failed. Do not use
+ // other members in that case. |operating_dir| is where the CrashService
+ // should store breakpad's checkpoint file. |dumps_path| is the directory
+ // where the crash dumps should be stored.
+ bool Initialize(const base::FilePath& operating_dir,
+ const base::FilePath& dumps_path);
// Command line switches:
//
@@ -120,4 +122,6 @@ class CrashService {
DISALLOW_COPY_AND_ASSIGN(CrashService);
};
-#endif // CHROME_TOOLS_CRASH_SERVICE_CRASH_SERVICE_H_
+} // namespace breakpad
+
+#endif // COMPONENTS_BREAKPAD_TOOLS_CRASH_SERVICE_H_

Powered by Google App Engine
This is Rietveld 408576698