Move CrashService class to breakpad component

Move CrashService class to breakpad component

BUG=247431
R=rsesek@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229279

[jochen (gone - plz use gerrit), 2013-10-17 01:36:56]

plz review

[Robert Sesek, 2013-10-17 13:16:05]

https://codereview.chromium.org/26688006/diff/7001/chrome/tools/crash_service...
File chrome/tools/crash_service/main.cc (right):

https://codereview.chromium.org/26688006/diff/7001/chrome/tools/crash_service...
chrome/tools/crash_service/main.cc:62: // The dumps path is typically : '<user
profile>\Local settings\
Does path case matter in windows? I think it's |Local Settings| and |Application
Data| if it does.

https://codereview.chromium.org/26688006/diff/7001/components/breakpad/tools/...
File components/breakpad/tools/crash_service.cc (right):

https://codereview.chromium.org/26688006/diff/7001/components/breakpad/tools/...
components/breakpad/tools/crash_service.cc:189: dumps_path_to_use =
base::FilePath(cmd_line.GetSwitchValueNative(kDumpsDir));
nit: 80cols (sucky, I know)

https://codereview.chromium.org/26688006/diff/7001/components/breakpad/tools/...
File components/breakpad/tools/crash_service.h (right):

https://codereview.chromium.org/26688006/diff/7001/components/breakpad/tools/...
components/breakpad/tools/crash_service.h:33: explicit CrashService();
No |explicit|

https://codereview.chromium.org/26688006/diff/7001/components/breakpad/tools/...
components/breakpad/tools/crash_service.h:38: bool Initialize(const
base::FilePath& operations_dir,
I don't know what an |operations_dir| is… comment?

This is also called |operating_dir| in the .cc file.

[jochen (gone - plz use gerrit), 2013-10-17 16:47:39]

https://codereview.chromium.org/26688006/diff/7001/chrome/tools/crash_service...
File chrome/tools/crash_service/main.cc (right):

https://codereview.chromium.org/26688006/diff/7001/chrome/tools/crash_service...
chrome/tools/crash_service/main.cc:62: // The dumps path is typically : '<user
profile>\Local settings\
On 2013/10/17 13:16:05, rsesek wrote:
> Does path case matter in windows? I think it's |Local Settings| and
|Application
> Data| if it does.

Done.

https://codereview.chromium.org/26688006/diff/7001/components/breakpad/tools/...
File components/breakpad/tools/crash_service.cc (right):

https://codereview.chromium.org/26688006/diff/7001/components/breakpad/tools/...
components/breakpad/tools/crash_service.cc:189: dumps_path_to_use =
base::FilePath(cmd_line.GetSwitchValueNative(kDumpsDir));
On 2013/10/17 13:16:05, rsesek wrote:
> nit: 80cols (sucky, I know)

Done.

https://codereview.chromium.org/26688006/diff/7001/components/breakpad/tools/...
File components/breakpad/tools/crash_service.h (right):

https://codereview.chromium.org/26688006/diff/7001/components/breakpad/tools/...
components/breakpad/tools/crash_service.h:33: explicit CrashService();
On 2013/10/17 13:16:05, rsesek wrote:
> No |explicit|

Done.

https://codereview.chromium.org/26688006/diff/7001/components/breakpad/tools/...
components/breakpad/tools/crash_service.h:38: bool Initialize(const
base::FilePath& operations_dir,
On 2013/10/17 13:16:05, rsesek wrote:
> I don't know what an |operations_dir| is… comment?
> 
> This is also called |operating_dir| in the .cc file.

Done.

[jochen (gone - plz use gerrit), 2013-10-17 16:47:39]

https://codereview.chromium.org/26688006/diff/7001/chrome/tools/crash_service...
File chrome/tools/crash_service/main.cc (right):

https://codereview.chromium.org/26688006/diff/7001/chrome/tools/crash_service...
chrome/tools/crash_service/main.cc:62: // The dumps path is typically : '<user
profile>\Local settings\
On 2013/10/17 13:16:05, rsesek wrote:
> Does path case matter in windows? I think it's |Local Settings| and
|Application
> Data| if it does.

Done.

https://codereview.chromium.org/26688006/diff/7001/components/breakpad/tools/...
File components/breakpad/tools/crash_service.cc (right):

https://codereview.chromium.org/26688006/diff/7001/components/breakpad/tools/...
components/breakpad/tools/crash_service.cc:189: dumps_path_to_use =
base::FilePath(cmd_line.GetSwitchValueNative(kDumpsDir));
On 2013/10/17 13:16:05, rsesek wrote:
> nit: 80cols (sucky, I know)

Done.

https://codereview.chromium.org/26688006/diff/7001/components/breakpad/tools/...
File components/breakpad/tools/crash_service.h (right):

https://codereview.chromium.org/26688006/diff/7001/components/breakpad/tools/...
components/breakpad/tools/crash_service.h:33: explicit CrashService();
On 2013/10/17 13:16:05, rsesek wrote:
> No |explicit|

Done.

https://codereview.chromium.org/26688006/diff/7001/components/breakpad/tools/...
components/breakpad/tools/crash_service.h:38: bool Initialize(const
base::FilePath& operations_dir,
On 2013/10/17 13:16:05, rsesek wrote:
> I don't know what an |operations_dir| is… comment?
> 
> This is also called |operating_dir| in the .cc file.

Done.

[Robert Sesek, 2013-10-17 17:21:21]

https://codereview.chromium.org/26688006/diff/17001/components/breakpad/tools...
File components/breakpad/tools/crash_service.cc (right):

https://codereview.chromium.org/26688006/diff/17001/components/breakpad/tools...
components/breakpad/tools/crash_service.cc:170: const base::FilePath&
report_path,
This doesn't match the signature in the other file.

[jochen (gone - plz use gerrit), 2013-10-17 17:55:29]

ptal

[Robert Sesek, 2013-10-17 17:56:26]

LGTM

[commit-bot: I haz the power, 2013-10-17 18:33:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jochen@chromium.org/26688006/35001

[commit-bot: I haz the power, 2013-10-18 01:27:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jochen@chromium.org/26688006/35001

[jochen (gone - plz use gerrit), 2013-10-18 02:19:39]

Committed patchset #4 manually as r229279 (presubmit successful).