tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 988cba66e31d5b6cc8570ad76b901902ab3f4564..2fd7152089bfa15af51ea057aa2716bec6e10301 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -446,6 +446,26 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="Android.CustomFeedback.Category"
+    enum="AndroidFeedbackCategory">
+  <owner>jwanda@chromium.org</owner>
+  <summary>
+    Recorded when the user selects a category button when in Custom Feedback UI.
+    This is recorded regardless if the user submits feedback. If the user does

[JJ, 2017/02/02 01:02:05]

Hm, I thought the change would clarify this. So it's recorded every time. To
clarify it this time I deleted the two sentences as they seem to be fluff and
don't talk specifically about the recording and it ended up confusing more than
helping.

+    submit feedback the final result is recorded within Product Specific Data
+    within their feedback.

[Mark P, 2017/02/02 00:28:39]

Justification / purpose is not necessary.  If you're willing to make the
justification public and think it'd be helpful for other people reading the
histogram, then it's fine to add it.

The key thing to talk about is have a description that's understandable to
everyone and clear about what it's recording / when it's emitted
https://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/metrics/histo...

You seem to have missed my other comment on this histogram.  I'll paste it into
this patchset.

[JJ, 2017/02/02 01:02:05]

Alright, thanks. Just making sure. I'm going to opt out of measuring it.

+  </summary>
+</histogram>
+
+<histogram name="Android.CustomFeedback.CategoryDetails"
+    enum="AndroidFeedbackCategoryDetails">
+  <owner>jwanda@chromium.org</owner>
+  <summary>
+    Recorded when a user selects an option related to their problem within the
+    Custom Feedback UI.
+  </summary>
+</histogram>
+
 <histogram name="Android.DownloadManager.Filter"
     enum="AndroidDownloadFilterType">
   <owner>dfalcantara@chromium.org</owner>
@@ -77544,6 +77564,45 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   <int value="4" label="EvictAll"/>
 </enum>
 
+<enum name="AndroidFeedbackCategory" type="int">
+  <summary>
+    This list corresponds to the categories the user can press when selecting a
+    category their feedback falls under.
+  </summary>
+  <int value="0" label="Error or blank page"/>
+  <int value="1" label="Chrome crashes or freezes"/>
+  <int value="2" label="Issues with website"/>
+  <int value="3" label="Trouble with something else"/>
+</enum>
+
+<enum name="AndroidFeedbackCategoryDetails" type="int">
+  <summary>
+    This list corresponds to all the possible options a user can press when
+    selecting an option their feedback falls under. Each option is prefixed with
+    a shortened name of the category that the option belongs to.
+  </summary>
+  <int value="0" label="Error Network error"/>
+  <int value="1" label="Error Blank page"/>
+  <int value="2" label="Error Video won't play"/>
+  <int value="3" label="Error Page won't download"/>
+  <int value="4" label="Error Can't connect to Wi-Fi"/>
+  <int value="5" label="Error Other"/>
+  <int value="6" label="Crash Watching videos"/>
+  <int value="7" label="Crash Downloading files"/>
+  <int value="8" label="Crash Browsing websites"/>
+  <int value="9" label="Crash Other"/>
+  <int value="10" label="Website Account or sign-in problems"/>
+  <int value="11" label="Website Advertisements"/>
+  <int value="12" label="Website Video won't play"/>
+  <int value="13" label="Website Slow website"/>
+  <int value="14" label="Website Broken or unreadable website"/>
+  <int value="15" label="Website Other"/>
+  <int value="16" label="Something Website"/>
+  <int value="17" label="Something Tabs"/>
+  <int value="18" label="Something Settings"/>
+  <int value="19" label="Something Other"/>
+</enum>
+
 <enum name="AndroidGATTConnectionErrorCodes" type="int">
   <summary>
     This list includes all errors from the Bluetooth Specification Version 4.2