milo/appengine/buildbot/pubsub.go - Issue 2668763002: Use a datastore batcher for build queries.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: milo/appengine/buildbot/pubsub.go

Issue 2668763002: Use a datastore batcher for build queries. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: milo/appengine/buildbot/pubsub.go

diff --git a/milo/appengine/buildbot/pubsub.go b/milo/appengine/buildbot/pubsub.go

index c12147af74e2d693d7092679271bab5f0bb8e1a7..b9bf2a4643a6565d044ee33802a4545e3c499d45 100644

--- a/milo/appengine/buildbot/pubsub.go

+++ b/milo/appengine/buildbot/pubsub.go

@@ -238,7 +238,7 @@ func doMaster(c context.Context, master *buildbotMaster, internal bool) int {

Eq("finished", false).

Eq("master", master.Name)

builds := []*buildbotBuild{}

- err = ds.GetAll(c, q, &builds)

+ err = getBuildQueryBatcher(c).GetAll(c, q, &builds)

if err != nil {

logging.WithError(err).Errorf(c, "Could not load current builds from master %s",

master.Name)