milo/appengine/buildbot/console.go - Issue 2668763002: Use a datastore batcher for build queries.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: milo/appengine/buildbot/console.go

Issue 2668763002: Use a datastore batcher for build queries. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: milo/appengine/buildbot/console.go

diff --git a/milo/appengine/buildbot/console.go b/milo/appengine/buildbot/console.go

index e1b45b92839b61d62fd9fdc9a283440f32c2ff6d..b77d6a4bbe3ff42fa80c29d3a17ca980e9c2112c 100644

--- a/milo/appengine/buildbot/console.go

+++ b/milo/appengine/buildbot/console.go

@@ -28,7 +28,7 @@ func getFullBuilds(c context.Context, masterName, builderName string, finished b

q = q.Order("-number")

q.Finalize()

buildbots := make([]*buildbotBuild, 0, 25)

- err := ds.GetAll(c, q, &buildbots)

+ err := getBuildQueryBatcher(c).GetAll(c, q, &buildbots)

return buildbots, err

}