Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp

Issue 2668753006: Special-case LocalDOMWindow for same-origin access in bindings. (Closed)
Patch Set: . Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp
diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp
index 5a28da3c1a938b921ba72730b291ddd6102bb96f..edc315badee4798e982a72447640b07124d679da 100644
--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp
+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp
@@ -58,7 +58,7 @@ namespace TestInterfaceCheckSecurityV8Internal {
static void readonlyLongAttributeAttributeGetter(const v8::FunctionCallbackInfo<v8::Value>& info) {
v8::Local<v8::Object> holder = info.Holder();
- TestInterfaceCheckSecurity* impl = V8TestInterfaceCheckSecurity::toImpl(holder);
+ LocalTestInterfaceCheckSecurity* impl = toLocalTestInterfaceCheckSecurity(V8TestInterfaceCheckSecurity::toImpl(holder));
v8SetReturnValueInt(info, impl->readonlyLongAttribute());
}
@@ -66,14 +66,14 @@ static void readonlyLongAttributeAttributeGetter(const v8::FunctionCallbackInfo<
static void longAttributeAttributeGetter(const v8::FunctionCallbackInfo<v8::Value>& info) {
v8::Local<v8::Object> holder = info.Holder();
- TestInterfaceCheckSecurity* impl = V8TestInterfaceCheckSecurity::toImpl(holder);
+ LocalTestInterfaceCheckSecurity* impl = toLocalTestInterfaceCheckSecurity(V8TestInterfaceCheckSecurity::toImpl(holder));
v8SetReturnValueInt(info, impl->longAttribute());
}
static void longAttributeAttributeSetter(v8::Local<v8::Value> v8Value, const v8::FunctionCallbackInfo<v8::Value>& info) {
v8::Local<v8::Object> holder = info.Holder();
- TestInterfaceCheckSecurity* impl = V8TestInterfaceCheckSecurity::toImpl(holder);
+ LocalTestInterfaceCheckSecurity* impl = toLocalTestInterfaceCheckSecurity(V8TestInterfaceCheckSecurity::toImpl(holder));
ExceptionState exceptionState(info.GetIsolate(), ExceptionState::SetterContext, "TestInterfaceCheckSecurity", "longAttribute");
@@ -95,7 +95,7 @@ static void doNotCheckSecurityLongAttributeAttributeGetter(const v8::PropertyCal
static void doNotCheckSecurityLongAttributeAttributeSetter(v8::Local<v8::Value> v8Value, const v8::PropertyCallbackInfo<void>& info) {
v8::Local<v8::Object> holder = info.Holder();
- TestInterfaceCheckSecurity* impl = V8TestInterfaceCheckSecurity::toImpl(holder);
+ LocalTestInterfaceCheckSecurity* impl = toLocalTestInterfaceCheckSecurity(V8TestInterfaceCheckSecurity::toImpl(holder));
ExceptionState exceptionState(info.GetIsolate(), ExceptionState::SetterContext, "TestInterfaceCheckSecurity", "doNotCheckSecurityLongAttribute");
@@ -118,7 +118,7 @@ static void doNotCheckSecurityReadonlyLongAttributeAttributeGetter(const v8::Pro
static void doNotCheckSecurityOnSetterLongAttributeAttributeGetter(const v8::PropertyCallbackInfo<v8::Value>& info) {
v8::Local<v8::Object> holder = info.Holder();
- TestInterfaceCheckSecurity* impl = V8TestInterfaceCheckSecurity::toImpl(holder);
+ LocalTestInterfaceCheckSecurity* impl = toLocalTestInterfaceCheckSecurity(V8TestInterfaceCheckSecurity::toImpl(holder));
v8SetReturnValueInt(info, impl->doNotCheckSecurityOnSetterLongAttribute());
}
@@ -146,7 +146,7 @@ static void doNotCheckSecurityReplaceableReadonlyLongAttributeAttributeGetter(co
}
static void voidMethodMethod(const v8::FunctionCallbackInfo<v8::Value>& info) {
- TestInterfaceCheckSecurity* impl = V8TestInterfaceCheckSecurity::toImpl(info.Holder());
+ LocalTestInterfaceCheckSecurity* impl = toLocalTestInterfaceCheckSecurity(V8TestInterfaceCheckSecurity::toImpl(info.Holder()));
ExceptionState exceptionState(info.GetIsolate(), ExceptionState::ExecutionContext, "TestInterfaceCheckSecurity", "voidMethod");
if (!BindingSecurity::shouldAllowAccessTo(currentDOMWindow(info.GetIsolate()), impl, exceptionState)) {

Powered by Google App Engine
This is Rietveld 408576698