Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2668753003: gl_gl_api_implemetation: DO API check instead of null fnptr checks (Closed)

Created:
3 years, 10 months ago by Corentin Wallez
Modified:
3 years, 10 months ago
Reviewers:
Geoff Lang, jbauman
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gl_gl_api_implementation: Check API type instead of null fnptr Some EGL implementation expose deprecated Desktop GL function on GL ES contexts. RealGLApi would call them and cause a GL_INVALID_OPERATION because the function is deprecated in core profile. TBR=jbauman@chromium.org BUG=686856

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M ui/gl/gl_gl_api_implementation.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Geoff Lang
lgtm
3 years, 10 months ago (2017-01-31 18:59:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2668753003/1
3 years, 10 months ago (2017-01-31 19:00:39 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/312907)
3 years, 10 months ago (2017-01-31 19:26:37 UTC) #8
Corentin Wallez
Seems like a shard just didn't get started.
3 years, 10 months ago (2017-01-31 19:27:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2668753003/1
3 years, 10 months ago (2017-01-31 19:28:41 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 19:38:11 UTC) #13
Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Powered by Google App Engine
This is Rietveld 408576698